RadioDroid icon indicating copy to clipboard operation
RadioDroid copied to clipboard

Kotlin conversion?

Open andrewshadura opened this issue 5 years ago • 7 comments

Would you be open to slowly converting RadioDroid to Kotlin? If yes, I could help you with that by doing the conversion work and submitting PRs :slightly_smiling_face:

Thanks for considering.

andrewshadura avatar Oct 09 '20 13:10 andrewshadura

My opinion is that just converting existing code without refactoring wouldn't be that useful. If there will be some major new feature - it would make sense to convert related code to Kotlin. Otherwise, the code is mostly unchanged and more or less stable.

Of course, any new code is welcomed to be written in Kotlin.

So I'm for:

  • Adding new code in Kotlin
  • Converting some piece of old code to Kotlin and refactoring it

I'll welcome any other arguments.

werman avatar Oct 09 '20 14:10 werman

Well, conversion will need some refactoring to be done anyway since idiomatic Java code doesn’t translate one-to-one to idiomatic Kotlin code.

andrewshadura avatar Oct 09 '20 14:10 andrewshadura

Ok, the initial question is whether we are open to slow conversion. I, personally, open to it, just a bit sceptical. However, I would try to review any changes. @segler-alex Do you have any opinion on this?

And if code becomes less ugly, I'll be grateful. Thank you for the interest in this project.

werman avatar Oct 10 '20 16:10 werman

i am open, but the person who is doing it has to fix bugs that come from the conversion. maybe we should even make a separate branch and give it to people as radiodroid3?

segler-alex avatar Oct 10 '20 20:10 segler-alex

i will not contribute code, i have enough to do for the backend

segler-alex avatar Oct 10 '20 20:10 segler-alex

I don't expect it to be especially error prone. Doing it piece by piece and improving some tests should be quite safe.

werman avatar Oct 10 '20 20:10 werman

Thanks for your opinions, I've started some work with relatively trivial conversions which however significantly reduce the amount of boilerplate.

andrewshadura avatar Oct 10 '20 20:10 andrewshadura