gdax.netcore icon indicating copy to clipboard operation
gdax.netcore copied to clipboard

Published 20 hours ago • verified publisher icon sefbkn

RealTimeClient Updates

Open ghost opened this issue 6 years ago • 2 comments

What is the best way to update this library. I am not familiar with github?

I have made some fixes locally on your lib for real time sockets and also your auth mechanism seemed to be incorrect (passphrase and signature was the wrong way around).

Should I fork or send a PR?

ghost avatar Nov 30 '17 21:11 ghost

@lucasmaximus you should fork, commit and push the changes to your fork, and then create the pull request. For more information, see this github doc: https://help.github.com/articles/creating-a-pull-request-from-a-fork/

It also looks like this has already been done in #14. This issue can be closed.

tekmaven avatar Dec 13 '17 01:12 tekmaven

TBH I've made a lot more changes now, and just decided to keep a local fork for my own purposes (Most of the authentication logic between GDAX and BitcoinAverage is basically the same so I basically made that much more generic and pulled a lot of that into a new C# project).

Thanks for the link to the manual, I normally use TFS (not online) so I dunno the procedure.

Glad the issue was fixed for someone else though 👍

ghost avatar Dec 15 '17 20:12 ghost