LightInject icon indicating copy to clipboard operation
LightInject copied to clipboard

Enabling Injection of Custom Validation Attributes in MVC Projects

Open aaronmell opened this issue 11 years ago • 4 comments

aaronmell avatar Jul 14 '14 15:07 aaronmell

Hi Aaron. I really appreciate the effort to improve LightInject.Mvc.

I will probably accept this pull request although I will wait until the the next version of LightInject is ready. We are currently doing an iOS/Android version.

Next I need to have tests for this as well as the build system for LightInject does not allow anything to be published unless we have 100% coverage. This might seem a little restrictive, but this rule has served me well :)

Finally we need to update the documentation for LightInject.Mvc so that users can see how to use this feature in their projects.

Best regards Bernhard Richter

seesharper avatar Jul 16 '14 14:07 seesharper

I don't mind writing some unit tests. I actually planned to do that, I'll update my pull request with the inclusion of some tests.

On Wed, Jul 16, 2014 at 9:12 AM, Bernhard Richter [email protected] wrote:

Hi Aaron. I really appreciate the effort to improve LightInject.Mvc.

I will probably accept this pull request although I will wait until the the next version of LightInject is ready. We are currently doing an iOS/Android version.

Next I need to have tests for this as well as the build system for LightInject does not allow anything to be published unless we have 100% coverage. This might seem a little restrictive, but this rule has served me well :)

Finally we need to update the documentation for LightInject.Mvc so that users can see how to use this feature in their projects.

Best regards Bernhard Richter

— Reply to this email directly or view it on GitHub https://github.com/seesharper/LightInject/pull/93#issuecomment-49170889.

aaronmell avatar Jul 16 '14 14:07 aaronmell

Great!!

Again, I really appreciate your contribution

Best regards Bernhard Richter

seesharper avatar Jul 16 '14 14:07 seesharper

Guys? Work or not?!

Nelo-cool avatar Jan 18 '19 14:01 Nelo-cool