nba_py icon indicating copy to clipboard operation
nba_py copied to clipboard

Published 20 hours ago • verified publisher icon seemethere

Update player.py and team.py

Open inoble opened this issue 6 years ago • 12 comments

I have found 24 endpoints from stats.nba.com that are not currently included in nba_py

Here are the first 6 new endpoints in 6 new classes that can hopefully be added to the master repo

I'm quite new to Python and GitHub so please let me know if I'm doing anything wrong, but hopefully I did enough testing on these classes before committing.

inoble avatar Feb 23 '18 13:02 inoble

the 'Travis CI' check timed out after 10 minutes.

Travis CI's documentation does not seem to offer any reason why this has occurred, but I notice that it's happened to previous commits.

inoble avatar Feb 23 '18 15:02 inoble

The IP addresses Travis uses are blocked by nba.com https://github.com/seemethere/nba_py/issues/88

bttmly avatar Feb 24 '18 00:02 bttmly

What are the future plans for this project if the tests don't pass? I'm willing and able to take on some of the monitoring of some of this stuff. @seemethere

rneu31 avatar Feb 27 '18 14:02 rneu31

Thanks @rneu31, it does seem a little quiet around here! I could help out if you need.

Is nba_py used by reddit.com/r/nba or any other websites? Do we have a list of websites that make use of the repo? I'm interested to find out more, it would be good to know contributions are going to be put to use.

inoble avatar Feb 27 '18 15:02 inoble

I'm also willing to contribute.

BenikaH avatar Mar 01 '18 17:03 BenikaH

If anybody else wants to help me out with these new 'endpoints', here are the endpoints I found that I'm yet to write up:

winprobabilitypbp teamandplayersvsplayers leagueplayerondetails leaguedashoppptshot infographicfanduelplayer franchiseplayers franchiseleaders fantasywidget defensehub boxscorematchups boxscoredefensive assisttracker assistleaders

inoble avatar Mar 20 '18 19:03 inoble

Hi @inoble , I am taking a stab at adding the endpoints you found. I'm curious, how did you find these? Also a question for you and anyone else watching this thread, any advice for decoding some of these variables? For example, endpoint winprobabilitypbp requires variable runtype which I have no idea what it does or what options are available.

mneedham91 avatar Mar 21 '18 16:03 mneedham91

Hi @inoble, I may have some free time this upcoming week. I’m open to helping out where I can.

BenikaH avatar Mar 21 '18 16:03 BenikaH

I’ve added features for leaguedashoppptshot already. I can merge my branch soon.

BenikaH avatar Mar 21 '18 17:03 BenikaH

@mneedham91 I stalked @seemethere's reddit comments and saw that he found the original 'endpoints' by checking a javascript file on nba.com. So I did the same and extracted all the endpoints.

The problem is I can't find it anymore! I just had a pretty good look again and had no luck.

inoble avatar Mar 21 '18 18:03 inoble

@inoble How's it coming with those endpoints? Anything you need help with?

BenikaH avatar Jul 26 '18 23:07 BenikaH

@BenikaH - I've not been working on this any further since February.

The endpoints that still need coding are:

winprobabilitypbp teamandplayersvsplayers leagueplayerondetails leaguedashoppptshot infographicfanduelplayer franchiseplayers franchiseleaders fantasywidget defensehub boxscorematchups boxscoredefensive assisttracker assistleaders

I might come back to this in the coming months because I might be trying to code my own simulation engine now that my sim league (dynastyfive.com) is ready to start its off season, but I can't guarantee it.

inoble avatar Jul 27 '18 07:07 inoble