Samples not showing in "Items in ISA" in "Batch permission changes"

[rabuono]

Describe the bug In Batch permission changes. When Samples are assigned to an Assay they disappear from the Items not in ISA, but they don't appear under their ISA asset in the Items in ISA menu

To Reproduce Steps to reproduce the behavior:

1. Create a Sample
2. Go to Batch permission changes and find it under Items not in ISA
3. Add it to an Assay
4. Go back to Batch permission changes. It is no longer under Items not in ISA, but it is also not under Items in ISA

Expected behavior The Samples assigned to an ISA asset should appear under that asset in the Items in ISA

[floradanna]

Just few comments to clarify the issue:

• samples are already included in batch sharing permission; only samples that are linked to assays disappear form batch sharing permission GUI. So this issue is about fixing an inconsistency or a bug.
• since the items are shown in a tree view, I would suggest to use the same style and graphic of the tree view already used in other pages (with dotted lines connecting little arrows etc)

[floradanna]

DataHub developed "batch sharing permission" for samples that have been:

• created via Single Page
• in a sample type that is linked to one study or to one assay

However, samples associated with ISA Study (but not with ISA Assay) are also visible as "Items not is ISA" when clicking My profile --> batch permission changes So, user can change permission of samples "linked" to ISA Study (but not ISA Assay) in DataHub also via "Items not is ISA".

[floradanna]

Samples associated with ISA Assay behave inconsistently: some samples are shown as "Items not in ISA", some other samples are not shown at all. To be investigated.

[floradanna]

related to PR #1551