seek icon indicating copy to clipboard operation
seek copied to clipboard

Deletion of CV term in use as sample title

Open floradanna opened this issue 11 months ago • 2 comments

Describe the bug If sample title is CV term, and the CV term is deleted, the sample cannot be selected and therefore it cannot be deleted nor edit it.

To Reproduce Steps to reproduce the behavior:

  1. Go to DataHub-test
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior Options:

  1. if deletion of CV term "in use" is allowed
  2. sample that uses the CV term as title should be editable or deletable

Image

Image

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

floradanna avatar Mar 05 '24 18:03 floradanna

It seemed like a bug because there is no possibility to delete the sample from sample view. The unexpected behaviour is due to the fact that the link associated with the sample title is the link to the CV term and not to the sample itself.

Fix: associate link to sample itself, and not to the CV term

floradanna avatar Mar 11 '24 09:03 floradanna

@floradanna @NielsGeudens

I can't reproduce the same behavior on our test instance, based on the information you gave me. When I delete the term used as a sample title. I can still delete the sample, no problem. I can also edit the sample but I can't save the changes unless I choose a valid CV term as sample title. This looks like correct behavior to me.

Could you point to the resource where this problem occurs?

kdp-cloud avatar Jun 24 '24 14:06 kdp-cloud