seek
seek copied to clipboard
Possible to create a Sample when not logged in
Describe the bug It is possible to create and save a Sample in the dynamic table without being logged in
To Reproduce Steps to reproduce the behavior:
- While on a incognito window and not logged in, go to https://datahub.dev.elixir-belgium.org/single_pages/6
- Click on Sources table of the
studying titles
Study - Click on add row
- Add values for the Sample in the created row in the dynamic table
- Click Save
- A new Sample is created
Expected behavior
Users not logged in should not be able to create Samples
Users logged in, but with only view
access to an Study/Assay in Single Page, should not be able to create a Sample in that Study/Assay
Screenshots
Sample a
is created without being logged in
Sample page for Sample a
, indicating JERM
as submitter.
Desktop (please complete the following information):
- OS: Windows 10
- Browser: Chrome
- Version: Version 106.0.5249.119 (Official Build) (64-bit)
- SEEK Instance: https://datahub.dev.elixir-belgium.org/
It is not possible to delete Samples in the described situation. Also not possible to use the Batch sharing permissions
button.
JERM submitter indicates the contributor is nil
We need to double check this for 1.13, at least with a couple of tests to make sure it isn't possible to create outside of the single page view. I'd expect we already have some tests but needs checking