seek icon indicating copy to clipboard operation
seek copied to clipboard

Sources, Samples and SOP associated to Study are not shown in Related Items

Open floradanna opened this issue 2 years ago • 6 comments

Describe the bug DataHub Sources and Samples and SOP created in a Study are:

  • shown in Unsorted item folder of the Project
  • not shown in Related items tab of the Study

To Reproduce Go to: https://datahub.test.elixir-belgium.org/single_pages/4 Click on Study --> Related Items:

  • there are SOP(3) and no samples

Expected behavior DataHub Sources and Samples created in a Study, and SOP associated with Study

  • should NOT appear in Unsorted item folder of the Project
  • should BE shown in Related items tab of the Study (Sources and Samples could be combined in just Samples (N) as in default SEEK)

Go to: https://datahub.test.elixir-belgium.org/single_pages/4 Click on Study --> Related Items:

  • It should be: SOP(1) and Samples(4)

floradanna avatar Jul 28 '22 09:07 floradanna

@vdkkia Please, check with @alaninmcr since he is doing some work on Related items.

floradanna avatar Jul 28 '22 09:07 floradanna

it should have 4 related SOPs, 1 directly to the study and 3 via the related assays

stuzart avatar Jul 28 '22 09:07 stuzart

I see. So, this is the rule in SEEK for Related items I guess.

Must we do the same for Samples then? Because in DataHub we link Samples to Study and each Assay also has samples. In Study Related items, should the number of Samples be the total number including the samples linked to Assays? In the example would be Samples(12) = 4 samples in Study and 8 across Assays

floradanna avatar Jul 28 '22 09:07 floradanna

  • Since SEEK doesn't show samples in Study Related items, we don't show it either.
  • As @stuzart suggested, we should enable SOP directly linked to Study to be shown in Study Related items, as well as the SOP from the linked Assays (in line with SEEK general rule). This is the case in SP advanced (I think).
  • We should find an "easy and clean" way to implement that "if SOP and Samples are directly linked to Study, they are NOT added to Unsorted folders (in folder view)". This is the case in SP advanced (I think). This seems to be the currently implemented rule for Assay related items as well.

floradanna avatar Jul 29 '22 13:07 floradanna

It should be fixed in DEV. However, it is difficult to check it with pre-existing items since the feature doesn't seem to be applied retrospectively to existing items.

  • Is this feature applied into test already?
  • when in test, can pre-existing items adapt/behave according to this new feature?

floradanna avatar Oct 03 '22 13:10 floradanna

I don't think there should be a reason why pre-existing items shouldn't appear if this has been fixed. It doesn't need applying retrospectively.

stuzart avatar Oct 03 '22 14:10 stuzart

it relates to issues labeled as "project-folder" and all folder-related issues.

floradanna avatar Nov 21 '22 17:11 floradanna