playroom icon indicating copy to clipboard operation
playroom copied to clipboard

Published 20 hours ago • verified publisher icon seek-oss

React 18 support

Open Moranilt opened this issue 2 years ago • 2 comments

Playroom does not support React 18 dependencies. It would be greate to add this support.

Moranilt avatar Jun 22 '22 11:06 Moranilt

Yep, started on this a few weeks ago but had to park for a bit. Was playing around with the approach, trying to avoid config if possible.

I'll loop back.

michaeltaranto avatar Jun 22 '22 11:06 michaeltaranto

@michaeltaranto Greate news! Thank you!

Moranilt avatar Jun 22 '22 12:06 Moranilt

any news on this? React is no longer required to be imported into components, and in fact recent typescript linting changes mean that you will get an error when you are importing react. However this then breaks playroom.

mogularpb avatar Nov 08 '22 23:11 mogularpb

Picked this up again between tasks and thought i'd share an update:

  • Added support for React 18, with backwards compatibility and zero config (drawing inspiration from Storybooks implementation)
  • The editor package (react-codemirror2) seems to be no longer updated and uses legacy React lifecycle APIs which are no longer supported.
  • Started working on migration to Codemirror 6, which is non-trivial requiring all features to be rewired to suit their new extension architecture.

Really want to get this work through, but our effort is definitely focused elsewhere in our ecosystem due to company priorities. I'll try to keep this issue updated.

michaeltaranto avatar Dec 07 '22 21:12 michaeltaranto

Actually, pivoted on this one. Given React still lets you use legacy lifecycle APIs, we have taken in a copy of the editor as a temporary workaround, while we look at upgrading to CodeMirror 6 separately.

This allows us to support React 18 (with backwards compatibility and no config/api change).

https://github.com/seek-oss/playroom/pull/265

michaeltaranto avatar Dec 08 '22 22:12 michaeltaranto