seedvault icon indicating copy to clipboard operation
seedvault copied to clipboard

Material3

Open theimpulson opened this issue 1 year ago • 4 comments

Sumary

This PR migrates Seedvault to use Material3.

Issues

  • https://github.com/seedvault-app/seedvault/issues/644

Test

Everything passes locally

theimpulson avatar Jun 24 '24 08:06 theimpulson

Switches look really bad right now. At best I can copy the colors from datura and design from AOSP's settingsLib but unless we have gradle builds or AOSP updates the material components library, it is going to look bad.

theimpulson avatar Jun 24 '24 08:06 theimpulson

> Task :app:ktlintMainSourceSetCheck FAILED
app/src/main/java/com/stevesoltys/seedvault/settings/preference/M3ListPreference.kt:47:1 Needless blank line(s) (no-consecutive-blank-lines)

grote avatar Jun 24 '24 12:06 grote

colors seem wrong here:

Screenshot_20240624_102718

grote avatar Jun 24 '24 13:06 grote

For some reason, the exclamation mark error icon isn't red anymore: Screenshot_20240624_103537

In dark theme it is even worse, because dark greyish.

grote avatar Jun 24 '24 13:06 grote

The only issue I can see right now is MD3 switches having wrong color in dark theme.

theimpulson avatar Jul 11 '24 09:07 theimpulson