seedvault
seedvault copied to clipboard
seedvault-app
[DO NOT MERGE] App strings reworked
Would be great to have this available for translation on Weblate in some form.
There are a lot of good changes here, but there's also some changes that I don't agree with. I only had a very cursory look and will come back to it again, but we had the same issue last time - this is such a big change all at once, making it harder to get merged.
I understand that it's easier to do it all at once, but smaller changes are easier for us to review and merge (like say anything that doesn't reword the string entirely, just changes application -> app and things like that)
I'll wait to see what the others have to say about it.
Friendly bump :)
@mikeNG perhaps we can manually extract and use some of these?
@chirayudesai Serves as yet another example of how to wrestle inconsistency from the hands of what has already been fixed. Every single translation is out of date for a start.
Every single translation is out of date for a start.
So this'd have to be rebased on top of android13, as that's what we're using now.
Getting translations switched over, that should help.
I can rebase it for you (if you don't mind, and have it set to allow that) - but the other point about there being too many changes to merge at once still stands.
Some can be merged right away, some after a quick discussion, and then others pending further discussion.
Will start replying to comments in a bit.
For example, I think one thing that could go on right away is
Disable/Enable -> Turn off / turn on, depending on context / somebody else double checking.
@comradekingu also if you're on matrix, we're at #seedvault-app:matrix.org
Given the number of changes still required here, and the fact that something this big will always run into friction.
We do want to improve the strings here, and we'll try to do it step by step to make it easier to manage all around.
Thanks!
@chirayudesai I think being given the work with no end in sight in two years doesn't bode well for the coming decades, but maybe I will come back to see it done someday.
@comradekingu I agree, but I did mention this a day after the PR got opened - https://github.com/seedvault-app/seedvault/pull/404#issuecomment-1122639062
Such big changes are hard to work with for us, and we can't just entirely re-do everything all at once.
There's so many strings I'd like to change, but it has to happen gradually, a few / related sections at a time, rather than all at once like this.
An example: https://github.com/seedvault-app/seedvault/pull/623
I even have two comments there about other possible changes I'd have liked to make, but I intentionally avoided doing it all at once - that just makes it hard to review and decide, and thus get merged.