seedvault icon indicating copy to clipboard operation
seedvault copied to clipboard

[UX] Restore: message strings improvements (past tense, …)

Open rugk opened this issue 3 years ago • 2 comments

When you restore some app data, the things it shows as reasons for data not being restored are somewhat strange… In general, they seem to not fix, because they seem to be the same as when the backup is made.

Here some improvments:

  • "not yet backed up" makes no sense, because well… we restore it, we will not back it up in the future (at least not with the data I/it did not restore or what) better: "not included in backup" (edit: or to be more precise I guess "was not backed up" in the past tense is okay/better)
  • "App does not allow backup" I wonder why it is then even listed to be tried to restore. (AFAIK other apps are not) Better, if we want to keep that information: "App did not allow backup" – past tense, because the backup was in the past.
  • "backup quota reached" may be a good thing to know during backup, but during restore well… Again maybe past tense? "Backup quote has been reached" – or past perfect, because well… the effect for our restoration is apparent.
  • Finally, the error message says "one error happened". Well… that's not the case. (it was rather the reverse, :sweat_smile:) Either count the errors and show the correct number or just say "One or more errors happened" or just something as generic as "Restoration process could not omplete successfully." Or, as said, you can also show the successful restores. "5 of X apps could be restored.".
  • Also: As for the things were an error happened (red symbol), it would be good to know a reason. Even a technical exception shown in a modal when you tap on it is better than nothing IMHO.

Also looking at the screenshots:

  • you need some horizontal padding, the title and the error message should not touch the edges of the screen

Screenshots

Screenshot_20210829-004424_Seedvault_notyetbacked_up

Screenshot_20210829-004500_Seedvault_NoSavingAllowed

Screenshot_20210829-004510_Seedvault_oneError

rugk avatar Aug 28 '21 23:08 rugk

There's already different text for backup/restore defined here: https://github.com/seedvault-app/seedvault/blob/d53f0fcde2202b79f83d7b77817e1face6c98e13/app/src/main/java/com/stevesoltys/seedvault/ui/AppBackupState.kt#L19-L41

Are you sure this is not a translation issue only? If not, maybe it doesn't detect properly that the restore text needs to be used.

grote avatar Aug 30 '21 08:08 grote

Are you sure this is not a translation issue only?

I'm obviously not, just used/"tested" the German version. Had a look at your contributing guide – respectively that small Readme section – (BTW, in case more contributors come, maybe I'd be good to expand that, but that's off-topic) – but could not find out where your translations are managed/whether there is a platform. I would certainly be happy to contribute, if there was an easy way…

Also notice the other things not related to the label defined there:

Finally, the error message says "one error happened".

and:

As for the things were an error happened (red symbol), it would be good to know a reason.

…and that minor padding issues.

If you want a seperate issue for anything, I can create that, no problem.

rugk avatar Aug 30 '21 19:08 rugk