seed icon indicating copy to clipboard operation
seed copied to clipboard

Add/update benchmarks for js-framework-benchmark

Open akhilman opened this issue 5 years ago • 2 comments
trafficstars

  • [ ] Update non keyed benchmarks.
  • [ ] Implement keyed benchmarks.

The key benchmark cannot be fully implemented (see https://github.com/krausest/js-framework-benchmark/issues/694). Our keyed VDOM implementation recreates one of the swapped element. The reason for this choice is that the browser still recalculates the element when it is moved inside the DOM.

Possible solutions:

  • Keep our implementation as is and add a note about this to the benchmark.
  • Postpone the removal of elements and reuse them in a new location if needed.

akhilman avatar May 05 '20 03:05 akhilman

When I was linting non-keyed implementation by benchmark's linter, it said that Seed behavior isn't strictly non-keyed. So the results aren't 100% comparable because each framework uses different algorithms. So.. if you think VDOM modification will make it better and helps to improve user apps - I'm ok with it. If we want to change VDOM to satisfy this benchmark, we shouldn't do it.

MartinKavik avatar May 05 '20 09:05 MartinKavik

Definitely agree do what's best for the user not an artificial benchmark.

rebo avatar May 09 '20 14:05 rebo