seebs

Rejection-matching

5

Consider the popular `errcheck` analysis tool, which verifies that things which return `error` don't have that return ignored. I can't figure out a way to express this in go-ruleguard. It...

## Summary It'd be nice to have a text size setting. ## Reproducing Open suggestions, paper tape, and dictionary windows. Note how two of them have a font setting. It...

``` // Maximum number of addressable IDs for logical processors in this physical package var MaxLogocalCPUId uint32 ```

runtime: Stack() calls lock against each other unnecessarily, even when single-goroutine

13

### What version of Go are you using (`go version`)? $ go version 1.19.2 ### Does this issue reproduce with the latest release? y ### What operating system and processor...

This is probably sorta insane, I just wanted to see if it could be done. Map members only define arguments for entries they have when the provided structure-or-map was scanned...

improve error messaging when I'm holding it wrong

1

This is probably related-ish to #83. I saw a note about this, thought "hey what a cool tool", tried to write things that would use spyql to read json. Consistently...

flag code used only by its own tests

1

staticcheck compiled from "did a git pull this afternoon" but on a different machine so it's hard to cut and paste output The code isn't easily extracted, but the basic...

SA4020 could be slightly more aggressive

1

``` type badRequest struct { error } type notFound error func checkError(e error) int { switch e.(type) { case badRequest: return http.StatusBadRequest case notFound: return http.StatusNotFound default: return http.InternalServerError }...

proposed test: Test functions should have some observable failure path

3

If a test function doesn't pass its `*testing.T` argument to anything, and doesn't ever call any methods on it, it's probably a test that was half-written and never finished. I've...

(version not relevant) `if len(x) > 0 && x[1] != '-'` In this code, taken from a real example, the *intent* is to determine whether x has a [1] before...