seebs

Results 35 comments of seebs

Unfortunately, I think that's sort of the opposite of what I want. What I want is a rule that matches "function returning T", but *doesn't* match "_ = [function returning...

(2) is idiomatic for "i am aware of this return value and i'm discarding it intentionally". Thus, when using something like `errcheck`, people will write `_ = fnReturningErr(...)` as a...

Yeah, I see only KR*GS, and I know that KW-GS and KR-GS also exist, because those are the ones I actually use.

To clarify: It appears to be intentional that goreman eats empty lines. There's an explicit check for line length being greater than one including the newline. Unfortunately, it's got a...

Interesting! Do you have a reproducer/test case? I tried to come up with some simple tests for the line handling behavior that PR 54 was addressing, and it passed those,...

On further study: This is actually intentional! See 8ddb825d. Possibly it shouldn't be, or should be optional, but it's actually intentional that empty lines get dropped.

I did note that runtime.Callers produces part of this data without locking, but there's no way to get the argument info, if you want it, and also there's no easy...

Idle thought: What about named return values? I can't figure out whether I'd expect `return ..., err` to overwrite them with zeros or leave them alone. Intuitively, I *think*, I...

I don't think it's *always* the case that `"%s"` is an error, which means it may not be a good candidate for auto-fixing. On the other hand, I should probably...

I just ran into this. The issue, I think, is that it seems weird to call a function "unused" if you can't compile without it. I think there's a distinction...