seebk
Plugin update.
New behaviour:
-
Fetch image metadata from gimp instead of reading it from the image file.
This makes possible to execute the plugin on an image that has been saved in the native XCF format.
Currently Exiv2 cannot read metadata from a XCF file.
Gimp uses Gexiv2. The plugin now needs to link this library too.
Changes in the implementation:
-
Ported from the old, deprecated, 2.8 API to the new one.
The plugin now uses GEGL buffers instead of 'GimpDrawable's
Miscellanea:
-
Reformat to better suit GIMP coding guidelines and GNU formatting.
-
Fixed a bunch of warns clang tidy was throwing at me.
Sorry, I know this should have been partitioned in several PRs to facilitate code review, but I have done it in a hurry as I needed the plugin to process a bunch of xcf files ASAP.
Thanks for all your work, an update to the new 2.10 API is long overdue. However, you are right that this patch would be really difficult to review and merge. It is more or less a complete replacement of the previous source. If you find a little more time to at least split it into a couple of separate commits that would help me a lot and make it more likely that I find the time to merge it. Please also take care that each commit stands for itself and does not contain whitespace edits like trimming of trailing spaces or tab-to-space conversions etc. There is also a lot of simple reordering of lines which clutters the diff although there is no change in code.
I should have done it properly since the start :face_with_head_bandage:
As soon as I have some free time I'll split this into 3 or 4 commits.
Thanks, still a lot of unecessary style changes but think I can look though it and merge the relevant parts.
I have created a new branch gimp-2.10 were I started to merge and edit your changes.
https://github.com/seebk/GIMP-Lensfun/tree/gimp-2.10
I am quite busy right now, might take some time until it is all there... But it's in the works ;)