Alireza comments

Results 872 comments of


                                            Alireza

test(visual-regression): Add tests and improve coverage

can you pull master?

test(visual-regression): Add tests and improve coverage

Can you please take a look at the unstable test in cypress? there is one in the study list that is flacky

[3.9-VV] Adopt Advanced Video Viewport: Migrate to the new advanced video viewport with additional capabilities.

https://www.cornerstonejs.org/docs/examples#video-viewport

[3.9-OP] Enhance On-Premise Deployment and Authentication Support: Improve on-premise deployment, authentication mechanisms, and documentation.

related https://github.com/OHIF/Viewers/issues/4084

[3.9-OP] Enhance On-Premise Deployment and Authentication Support: Improve on-premise deployment, authentication mechanisms, and documentation.

Requirements Gathering for OHIF On Prem Deployment: [docs.google.com/document/d/144p_P8BynqIdIzsyKwfg3p7mZBW3dyV4ReL2scTl0Dc/edit?usp=sharing](https://docs.google.com/document/d/144p_P8BynqIdIzsyKwfg3p7mZBW3dyV4ReL2scTl0Dc/edit?usp=sharing)

[3.9-OP] Enhance On-Premise Deployment and Authentication Support: Improve on-premise deployment, authentication mechanisms, and documentation.

https://github.com/OHIF/Viewers/issues/4185

[3.9-OP] Enhance On-Premise Deployment and Authentication Support: Improve on-premise deployment, authentication mechanisms, and documentation.

https://github.com/OHIF/Viewers/issues/4133

[3.9-OP] Enhance On-Premise Deployment and Authentication Support: Improve on-premise deployment, authentication mechanisms, and documentation.

Fixed here https://github.com/OHIF/Viewers/pull/4234

Updating the _validateRequiredSelectors method

How can we test it? what was not working that is now after this PR working?

Updating the _validateRequiredSelectors method

Are we moving to shadcn components? If so, can we hold off on this? Or do you need it?