synthoseis icon indicating copy to clipboard operation
synthoseis copied to clipboard

closures.write_closure_info_to_log(seismic.rfc_raw[1:4, ...])

Open klaas-koster opened this issue 7 months ago • 4 comments

The call in main.py to write_closure_info_to_log() is hardwired to pass on the second, third, and fourth angle. That looks like a remnant from the past where the code assumed the user always specified three angles in the configuration file and the code padded those with a 0- and 45-degree response. I suggest changing

closures.write_closure_info_to_log(seismic.rfc_raw[1:4, ...])

to

closures.write_closure_info_to_log(seismic.rfc_raw[:, ...])

Note, that this is not guaranteed to give good results if the user specifies just one angle in the configuration file.

I am now seeing that I sometimes still get 5 angles in rfc_raw when I specify 3 in the configuration file. In that case my fix above does not work because the code is now trying to match 5 RFCs with 3 angles.

I need to figure out why I sometimes get 3 and other times 5 angles in rfc_raw...

klaas-koster avatar Jul 15 '24 19:07 klaas-koster