import-linter icon indicating copy to clipboard operation
import-linter copied to clipboard

Published 20 hours ago • verified publisher icon seddonym

tests and CI for `import-linter`

Open skarzi opened this issue 4 years ago • 5 comments

I am opening this issue to talk about CI and testing approach in this great package. We can start from discussing following points:

  1. Why travis is not fully integrated with project? Usually CI systems use github's checks to give info about build result etc which is really handy - example of github checks with travis
  2. What do you say for migrating from travis to github actions and workflows?
  3. Is tox really needed? Maybe travis build matrix or github workflows strategy matrix will be enough?
  4. What do you think about services like codecov? It's free for open source projects and can help us to get 100% code coverage and then keep it as this level

skarzi avatar Aug 02 '20 13:08 skarzi

Hi Łukasz,

Thanks for getting involved, and the PR!

Very much open to the improvements you mention - however changing everything comes with a time cost to review and understand the new processes - and I'm not feeling much pain with the current ones. However, if it helps others feel more able to contribute then that's worthwhile - I just might not be able to review things promptly.

Responding to each:

  1. Why travis is not fully integrated with project?

It should already be integrated with the checks that appear on the main 'conversation' tab of the PR - just not with the Github checks tab (which I haven't used elsewhere).

  1. What do you say for migrating from travis to github actions and workflows?

I don't feel strongly.

  1. Is tox really needed? Maybe travis build matrix or github workflows strategy matrix will be enough?

Yes possibly, again I don't feel strongly.

  1. What do you think about services like codecov?

I think it's great, and have used it on other projects.

seddonym avatar Aug 08 '20 11:08 seddonym

Maybe let's start from introducing codecov to the project, what do you think?

skarzi avatar Dec 23 '20 13:12 skarzi

Sure! Happy to review a PR. Thanks Łukasz!

seddonym avatar Dec 29 '20 09:12 seddonym

I suggest staying with tox. It simplifies local testing.

Czaki avatar May 04 '21 14:05 Czaki

Would be great to add mypy check to CI with quite strict configuration (and appropriate typing), it would make contributions a lot easier :)

jakub-borusewicz avatar Oct 22 '21 10:10 jakub-borusewicz

I'm going to close this ticket as we have now migrated to Github actions. Feel free to open individual tickets for the other suggestions.

seddonym avatar Feb 03 '23 14:02 seddonym