David Seddon comments

Results 219 comments of


                                            David Seddon

Find circular dependencies

> If you remove any edge it can affect other cycles, not only the recently found one, right? Yes exactly. Bear in mind that the last time I ran a...

Find circular dependencies

I agree, I think `acyclic` is a good name for the contract type.

Add as_packages parameter to find_shortest_chains

Great stuff! Thanks for all your help.

@nathanjmcdougall Looking at this again, with a better understanding of precommit, I'm leaning towards merging this change. Although using `language: system` may have drawbacks, surely it's better than the tool...

Fix pre-commit-hook

Thanks for the detailed answer @nathanjmcdougall, I appreciate it. > But then when you try and commit, it will try and access the system Python installation, which may not even...

Fix pre-commit-hook

Ah that makes sense. Thanks - I'll do as you suggest, as well as removing the `language: python` which is not correct, as it won't pick up on changes to...

Fix pre-commit-hook

I'm closing this PR in favour of https://github.com/seddonym/import-linter/pull/268 - comments welcome! I'll merge in the next few days, let me know if you want me to hold off so either...

Unable to create simple contract - django models

Thanks for raising the issue! What's happening here is that because `core.*.models` are covered by the `core.*` expression, Import Linter is rejecting it - it doesn't make sense for modules...

Proposal: introduce Ruff and make mypy more strict

I like the idea, happy to consider a pull request!

Support for `<thirdparty>` and `<stdlib>` keywords

Thanks for your contribution! I will aim to review in the next few days.