blake2 icon indicating copy to clipboard operation
blake2 copied to clipboard

a couple of noticeable bugs

Open amitceder opened this issue 6 years ago • 2 comments

hi, just wanted to comment on a few issues i notice - comparing the code to c code: in blake2_core.v, signal t_ctr_inc is never getting a "1" value . it's stuck on '0' hence causing the mechanism to fail on the first iteration of v_reg.

in addition - on blake2.v line 190 - it should be: block_mem[address[5 : 0]-ADDR_BLOCK_W00] <= write_data; since otherwise you get wrapping of the lower 5 bits of the address causing wrong writing of the data.

amitceder avatar Dec 10 '19 16:12 amitceder

Note the status in the README file: "Not done Does not work."

secworks avatar Dec 10 '19 16:12 secworks

Thank you for the reporting. There are several bugs in the design. It is far from complete. Unfortunately I haven't had time for a long while to complete the core.

secworks avatar Dec 10 '19 16:12 secworks