react-ace icon indicating copy to clipboard operation
react-ace copied to clipboard

No support for server-side rendering

Open mathew-kurian opened this issue 10 years ago • 22 comments

mathew-kurian avatar Jul 23 '15 06:07 mathew-kurian

Would be happy to have a PR for this.

securingsincity avatar Jul 26 '15 18:07 securingsincity

Since your dependencies are not built for serverside rendering, it will be pretty challenging. For now, I would recommend users should just use a client-rendered React components if they want to use your lib which is what I did. But, I have made some minor modifications in my fork which should improve performance. Also, this fork is not optimized for a PR. If you want, I can prepare it.

mathew-kurian avatar Jul 27 '15 04:07 mathew-kurian

I just ran into this same issue. One possible solution is to pull in brace in another way separate from you main bundle. The client required javascript anyway, so at least you can render the rest of the page.

psayre23 avatar Dec 15 '15 04:12 psayre23

from what I've seen, Ace uses the DOM api directly to create the editor. Wouldn't it be possible to use something like jsdom to simulate a browser environment on the server?

gabipurcaru avatar Dec 17 '15 10:12 gabipurcaru

NextJS offers great support for React.JS server-side rendered applications. They have the dynamic function where it allows you to import client side only.

The implementation that I use. Client Side Component

import brace from 'brace';
import 'brace/mode/javascript';
import 'brace/mode/c_cpp';
import 'brace/theme/twilight';
import 'brace/theme/xcode';
import AceEditor from 'react-ace';

const textEditor = (props) => (
  <div>
    <AceEditor
        mode={props.lan}
        theme={props.theme}
        onChange={props.onChange}
        name="UNIQUE_ID_OF_DIV"
        editorProps={{
            $blockScrolling: true
        }}
        fontSize={21}
        height='80vh'
        width='100%'
    />
  </div>
)

export default textEditor

`

How to import

import React, { Component } from 'react
import dynamic from 'next/dynamic'
const TextEditor = dynamic(import('../components/textEditor'), {
  ssr: false
})
 
 export default class Index extends Component {
    ...
    render() {
        return (
          <div>
	       <TextEditor lan='javascript' theme="twilight"/>
          </div>
	    )
    }

saulflores95 avatar May 29 '18 20:05 saulflores95

is there any side effect of using "next/dynamic" ? or it's fine to use that..

prtvora99 avatar Jul 24 '18 11:07 prtvora99

I have not seen any issues, duly noted that I am following the Next,JS framework guidelines on how to develop.

saulflores95 avatar Jul 25 '18 05:07 saulflores95

Very sad(((

Fi1osof avatar Dec 09 '18 08:12 Fi1osof

https://github.com/JedWatson/react-codemirror/issues/77

x5engine avatar Jan 14 '19 01:01 x5engine

Very interested in this. We are using Ace and love it but haven't found a way to use it with Gatsby yet.

ezeev avatar Apr 08 '19 16:04 ezeev

@saulflores95 has the right idea in my case the mode and theme had to be dynamically imported as well. But when I did that I don't think those were being imported before the default react ace component was so I didn't see my theme. I had to await the main import before I imported the ace builds theme and mode. This is version 8.0.0.

const Editor = dynamic(
  async () => {
    const ace = await import('react-ace');
    import('ace-builds/src-noconflict/mode-javascript');
    import('ace-builds/src-noconflict/theme-textmate');
    return ace;
  },
  {
    // eslint-disable-next-line react/display-name
    loading: () => (
      <NoContent style={{ height: '520px' }}>
        <Spinner diameter={100} />
      </NoContent>
    ),
    ssr: false,
  },
);

JohnGrisham avatar Mar 11 '20 22:03 JohnGrisham

#841 was merged for 9.0.0 and should solve support for server-side rendering. thanks to @gchallen

securingsincity avatar May 23 '20 02:05 securingsincity

Just as an FYI, my PR does not enable full SSR. It just prevents react-ace from failing when used on the server. All that will be rendered on the server is blank div which Ace will fill in once it is loaded on the client.

I've been working on more complete support for SSR, meaning actually generating markup on the server similar to what you would find on the client after Ace loads. This is non-trivial, since Ace does some fairly nasty and convoluted layout calculations on load that will need to be mocked out in jsdom. So getting something that looks like what you'd see client side will probably require passing some of those layout constants.

Anyway—this is definitely a step in the right direction. Now that react-ace doesn't blow up SSR, it should be possible to implement more complex SSR approaches using a wrapper component.

gchallen avatar May 23 '20 13:05 gchallen

Thank you @JohnGrisham, your solution worked for me. I did have to replace the imports with requires however

const Ace = dynamic(
  async () => {
    const ace = await import('react-ace');
    require('ace-builds/src-noconflict/mode-mysql');
    require('ace-builds/src-noconflict/theme-xcode');
    return ace;
  },
{
  loading: () => (
    <>Loading...</>
  ),
  ssr: false,
})
...
<Ace mode="mysql"  theme="xcode"  />

pythonruss avatar Dec 03 '20 21:12 pythonruss

@saulflores95 has the right idea in my case the mode and theme had to be dynamically imported as well. But when I did that I don't think those were being imported before the default react ace component was so I didn't see my theme. I had to await the main import before I imported the ace builds theme and mode. This is version 8.0.0.

const Editor = dynamic(
  async () => {
    const ace = await import('react-ace');
    import('ace-builds/src-noconflict/mode-javascript');
    import('ace-builds/src-noconflict/theme-textmate');
    return ace;
  },
  {
    // eslint-disable-next-line react/display-name
    loading: () => (
      <NoContent style={{ height: '520px' }}>
        <Spinner diameter={100} />
      </NoContent>
    ),
    ssr: false,
  },
);

Working partially, mode and theme missing (also tried using require instead of import).

Starting with npm run dev (which runs next dev).

Google Chrome 87 console outputs this error:

Unable to infer path to ace from script src, use ace.config.set('basePath', 'path') to enable dynamic loading of modes and themes or with webpack use ace/webpack-resolver

Also noticed 404 status code for this requests:

  • http://localhost:3000/courses/mode-javascript.js
  • http://localhost:3000/courses/theme-monakai.js

If instead I use this other approach:

// code-editor.js
import AceEditor from 'react-ace'
import 'ace-builds/src-noconflict/mode-javascript'
import 'ace-builds/src-noconflict/theme-monokai'

const handleOnChange = () => {
  console.log('Changed!')
}

export default function CodeEditor() {
  return (
    <AceEditor
      mode="javascript"
      theme="monakai"
      onChange={handleOnChange}
      name="editor01"
    />
  )
}

// hello-world.js
import dynamic from 'next/dynamic'

const CodeEditor = dynamic(
  () => import('../../components/code-editor'),
  { ssr: false },
)

export default function HelloWorld() {
  return <CodeEditor />
}

I get the same error but slightly different 404 errors:

  • http://localhost:3000/courses/theme-monakai.js
  • http://localhost:3000/courses/worker-javascript.js (this one is new)

runoncedev avatar Jan 03 '21 01:01 runoncedev

... // hello-world.js import dynamic from 'next/dynamic'

const CodeEditor = dynamic( () => import('../../components/code-editor'), { ssr: false }, )

export default function HelloWorld() { return <CodeEditor /> }


I get the same error but slightly different 404 errors:

* http://localhost:3000/courses/theme-monakai.js
* http://localhost:3000/courses/worker-javascript.js (this one is new)

Was able to prevent that by setting the useWorker option to false

<CodeEditor
   ...
  setOptions={{
    useWorker: false,
  }}
/>

nopol10 avatar Jul 24 '21 15:07 nopol10

hi~,i'm use next and react-ace create playground

cc7gs avatar Aug 26 '21 16:08 cc7gs

Hi guys!

I deployed my app on vercel, and my dynamic component, (dynamic Ace Code Editor) not showing up, although on my localhost it is working great, but on the deployed site it is rendered empty. Anyone experienced this strange behaviour, and found a solution for it? image

(I have followed @saulflores95 idea, with next/dynamic)

radikris avatar Feb 15 '22 07:02 radikris

same as @radikris, production build is not rendering it.

danr-za avatar Mar 28 '22 14:03 danr-za

@radikris did you add the ssr:false key?

saulflores95 avatar Apr 07 '22 15:04 saulflores95

same as @radikris , any updates on the production build not rendering?

nealchen-cn avatar Jun 06 '22 10:06 nealchen-cn

@saulflores95 has the right idea in my case the mode and theme had to be dynamically imported as well. But when I did that I don't think those were being imported before the default react ace component was so I didn't see my theme. I had to await the main import before I imported the ace builds theme and mode. This is version 8.0.0.

const Editor = dynamic(
  async () => {
    const ace = await import('react-ace');
    import('ace-builds/src-noconflict/mode-javascript');
    import('ace-builds/src-noconflict/theme-textmate');
    return ace;
  },
  {
    // eslint-disable-next-line react/display-name
    loading: () => (
      <NoContent style={{ height: '520px' }}>
        <Spinner diameter={100} />
      </NoContent>
    ),
    ssr: false,
  },
);

Worked for me 👍 but had to add await to all imports otherwise I was getting aforementioned errors like

Unable to infer path to ace from script src, use ace.config.set('basePath', 'path') to enable dynamic loading of modes and themes or with webpack use ace/webpack-resolver

GET http://localhost:3000/widget/mode-javascript.js net::ERR_ABORTED 404 (Not Found)

GET http://localhost:3000/widget/theme-textmate.js net::ERR_ABORTED 404 (Not Found)

async () => {
  const ace = await import('react-ace');
  await import('ace-builds/src-noconflict/mode-javascript');
  await import('ace-builds/src-noconflict/theme-textmate');
  return ace;
},

Also important step, as mentioned above, is to set useWorker: false

<Editor
   ...
  setOptions={{
    useWorker: false,
  }}
/>

FilipPyrek avatar Aug 20 '22 19:08 FilipPyrek