securingsincity
Open to a better diff?
Hi,
I'm a bit frustrated with the DiffViewer component. The underlying diff algorithm is pretty trivial, and doesn't seem to properly recover. As an example, compare the following: const s1 = [1, 2 ,3, 6, 7, 8, 9, 10].map(i => "line " + i).join("\n"); const s2 = [1, 2 ,3, 4, 5, 6, 7, 10].map(i => "line " + i).join("\n"); It will NOT detect that line 6 and line 7 are common... a pretty frequent case when dealing with code imho. Also I'd want to have a diff visualization that spans across both panes. I'll happily submit corresponding PRs if it makes sense, what do you think ?
Hi, a diff viewer component would be welcome in underlying ace project too. We have an old implementation that uses diff_match_patch internally https://github.com/c9/core/blob/master/plugins/c9.ide.scm/diff/index.html, but it doesn't work very well either
