openfl icon indicating copy to clipboard operation
openfl copied to clipboard
verified publisher icon securefederatedai

Improved logging in collaborator module

Open rahulga1 opened this issue 8 months ago • 3 comments

Summary

Enhance error handling in Collaborator module.

Type of Change (Mandatory)

Specify the type of change being made.

  • Feature enhancement

Description (Mandatory)

Enhance error handling in Collaborator module. Added try-except blocks to manage exceptions during the execution of collaborator rounds and while starting the collaborator service. Critical errors are now logged, and appropriate messages are displayed to the user, ensuring smoother operation and clearer feedback in case of failures.

Testing

Local Testing

rahulga1 avatar May 15 '25 09:05 rahulga1

Run once PQ as well. It has ellaborated set of tests.

payalcha avatar May 15 '25 13:05 payalcha

Please hold off on merging this until #1575 is merged, as that PR introduces significant changes to the collaborator code. Merging this now will likely cause substantial merge conflicts and may require an overwrite.

Additionally, do we know if this PR addresses the silent crashes, or at a minimum, provides relevant evidence?

Sure Karan, will wait for the other PR to merge, I have seen the benefit of this which helped me to debug the mnist pipeline failure which was happening due to my change. Anyways I will share again the screenshot after updated PR to show the usability of it.

rahulga1 avatar May 15 '25 15:05 rahulga1

@teoparvanov @MasterSkepticista in the meantime, I will appreciate if you have other feedback about the changes, which I can take care of.

rahulga1 avatar May 15 '25 15:05 rahulga1