MacYTDL icon indicating copy to clipboard operation
MacYTDL copied to clipboard

Missing vtt subtitles in batch mode

Open macmeister1967 opened this issue 1 year ago • 10 comments

I recently tried to get about 9 episodes of two series which contain VTT subtitles. I had preferences set to "Best" for subtitles, and it downloaded the first one, but no more. I then tried them one at a time with preferences set to VTT and they all downloaded correctly.

This was ABC iView in Australia :-)

macmeister1967 avatar Oct 31 '23 02:10 macmeister1967

Can you provide the iView URL ? So far, it's working for me but, it might depend on the particular iView show.

UPDATE: There is a bug causing a spurious error msg:

string indices must be integers, not 'str'

Doesn't seem to cause problems with downloads.

section83 avatar Oct 31 '23 04:10 section83

https://iview.abc.net.au/show/fake-or-fortune/series/5

I did try and batch from multiple seasons (3/4/5)

And remember, subtitle format was set on BEST.

Cheers.

On Tue, 31 Oct 2023 at 15:37, Vincentius @.***> wrote:

Can you provide the iView URL ? So far, it's working for me but, it might depend on the particular iView show.

— Reply to this email directly, view it on GitHub https://github.com/section83/MacYTDL/issues/71#issuecomment-1786434193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLSXIOQNORWK3YLNBNTTYDYCB6BHAVCNFSM6AAAAAA6W7OE5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBWGQZTIMJZGM . You are receiving this because you authored the thread.Message ID: @.***>

macmeister1967 avatar Oct 31 '23 21:10 macmeister1967

I had no trouble doing a normal download. I'll try a couple of ideas with the batch function. In the meantime, can you post here a copy of the contents of this file:

[your Mac]/Users/[your Home]/Library/Preferences/MacYTDL/BatchFile.txt

Thanks.

UPDATE: There is a bug somewhere in my code. I think I know where. Many thanks for reporting the problem. I'll have a fix in the next release. Meanwhile, you can download two or more videos in one process by pasting their URLs into the "Main" dialog text box with spaces between. Also, you can use the iView Chooser dialog to choose the episodes of an iView show you wish to download (I'll have a fix for the spurious error too).

Chers.

section83 avatar Oct 31 '23 22:10 section83

Sadly, that file is now empty... try a batch from two seasons on SUBTITLE=BEST, see if the 2nd and 3rd subtitles download (that was my issue... normally the VTT files downloads BEFORE the video/audio, so it was noticeable when that didn't happen!

On Wed, 1 Nov 2023 at 10:00, Vincentius @.***> wrote:

I had no trouble doing a normal download. I'll try a couple of ideas with the batch function. In the meantime, can you post here a copy of the contents of this file:

[your Mac]/Users/[your Home]/Library/Preferences/MacYTDL/BatchFile.txt

Thanks.

— Reply to this email directly, view it on GitHub https://github.com/section83/MacYTDL/issues/71#issuecomment-1788149732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLSXIJ6SU4Y7RPTS5RATVTYCF7HLAVCNFSM6AAAAAA6W7OE5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGE2DSNZTGI . You are receiving this because you authored the thread.Message ID: @.***>

macmeister1967 avatar Nov 01 '23 00:11 macmeister1967

Yes, sorry. It was a "successful" download so, the batch list was cleared.

The code which does a batch download ignores the subtitles setting. I've fixed that and it will be in release 1.26 (or 1.25.1 if that happens).

Cheers.

section83 avatar Nov 01 '23 02:11 section83

Many thanks... the subtitles are a must for me. Hate how 7+ doesn't seem to have a single subtitle, or an option in the player to even ENABLE subtitles :-(

On Wed, 1 Nov 2023 at 13:59, Vincentius @.***> wrote:

Yes, sorry. It was a "successful" download so, the batch list was cleared.

The code which does a batch download ignores the subtitles setting. I've fixed that and it will be in release 1.26 (or 1.25.1 if that happens).

Cheers.

— Reply to this email directly, view it on GitHub https://github.com/section83/MacYTDL/issues/71#issuecomment-1788327395, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLSXIJWCKDMVONPNWBI5IDYCG3IHAVCNFSM6AAAAAA6W7OE5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGMZDOMZZGU . You are receiving this because you authored the thread.Message ID: @.***>

macmeister1967 avatar Nov 01 '23 11:11 macmeister1967

7+ doesn't seem to have a single subtitle, or an option in the player to even ENABLE subtitles

I think it varies with the show. Some don't have closed captions while others do. For example there is a closed captions logo in the top RH corner for this show:

Screenshot 2023-11-02 at 11 46 32 am

section83 avatar Nov 02 '23 00:11 section83

DAyum!

I need to keep a whether eye out for that. I was looking at downloading Bargain Hunt, and it does not seem to be subtitled at all, occasionally we spot it on another channel, and it DOES have subtitles, so I guess it is what that channel is prepared to pay, or what time it is shown? (I know there is a self-policing policy of 6pm - 10pm requiring subtitles for the deaf/hard of hearing).

Still, great news about CC on 7

On Thu, 2 Nov 2023 at 11:48, Vincentius @.***> wrote:

7+ doesn't seem to have a single subtitle, or an option in the player to even ENABLE subtitles

I think it varies with the show. Some don't have closed captions while others do. For example there is a closed captions logo in the top RH corner for this show:

[image: Screenshot 2023-11-02 at 11 46 32 am] https://user-images.githubusercontent.com/7471595/279833764-42c7fcfb-6c23-4acf-bcb3-c942ee8dd34c.png

— Reply to this email directly, view it on GitHub https://github.com/section83/MacYTDL/issues/71#issuecomment-1789888571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLSXIORYILWJ6JME6NXBKDYCLUXRAVCNFSM6AAAAAA6W7OE5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZHA4DQNJXGE . You are receiving this because you authored the thread.Message ID: @.***>

macmeister1967 avatar Nov 02 '23 01:11 macmeister1967

PS. I use https://www.happyscribe.com/subtitle-tools/subtitle-converter/

to convert my VTT to SRT.

I don't know if they have an API at all, but that would be a neat feature in your frontend - if you could automate the conversion, seeing 99% of what I have found is VTT subtitles?!

Cheers!

On Thu, 2 Nov 2023 at 12:40, Craig Cooper @.***> wrote:

DAyum!

I need to keep a whether eye out for that. I was looking at downloading Bargain Hunt, and it does not seem to be subtitled at all, occasionally we spot it on another channel, and it DOES have subtitles, so I guess it is what that channel is prepared to pay, or what time it is shown? (I know there is a self-policing policy of 6pm - 10pm requiring subtitles for the deaf/hard of hearing).

Still, great news about CC on 7

On Thu, 2 Nov 2023 at 11:48, Vincentius @.***> wrote:

7+ doesn't seem to have a single subtitle, or an option in the player to even ENABLE subtitles

I think it varies with the show. Some don't have closed captions while others do. For example there is a closed captions logo in the top RH corner for this show:

[image: Screenshot 2023-11-02 at 11 46 32 am] https://user-images.githubusercontent.com/7471595/279833764-42c7fcfb-6c23-4acf-bcb3-c942ee8dd34c.png

— Reply to this email directly, view it on GitHub https://github.com/section83/MacYTDL/issues/71#issuecomment-1789888571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLSXIORYILWJ6JME6NXBKDYCLUXRAVCNFSM6AAAAAA6W7OE5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZHA4DQNJXGE . You are receiving this because you authored the thread.Message ID: @.***>

macmeister1967 avatar Nov 02 '23 01:11 macmeister1967

, seeing 99% of what I have found is VTT subtitles?!

Yes, VTT is common.

if you could automate the conversion,

Usually, if you set "Subtitles format" to "srt" or something you want, MacYTDL will download what's available and convert it to what you want. However, there is a problem with "webvtt" which is the format used by iView. I need to do more research on why it's not working.

Thanks.

section83 avatar Nov 02 '23 09:11 section83