flower icon indicating copy to clipboard operation
flower copied to clipboard

WIP Frontend Refactor

Open giulioz opened this issue 5 years ago • 4 comments

Closes #32

giulioz avatar Sep 08 '20 12:09 giulioz

Thanks for this huge pr! If time allows, would be better to split it into several few smaller ones:

  • One for the formatting changes to non-code related files
  • One with only the changes to use typescript (modifying only one js file, to make sure it works)
  • One on top of the last one, with all the other changes

If you don't have much time, then just split the random formatting changes from the js->tsx refactor plz.

Ideally would be better to make the changes to js files as a rename, and not as a deletion and addition. According to this the best strategy is to first rename them in a commit and then apply the content changes.

If you don't have time for the things above, just make the tests pass and I will try to do the rest :)

nicomazz avatar Sep 14 '20 18:09 nicomazz

Actually I've done a single commit because I wanted to make it at least build, I don't like broken commits. Unfortunately it was pretty difficult to move between compiling states without making a mess.

If you want splitted commits I can do it, but it's still a WIP, I wanted to fix more things before merging the PR. Right now the frontend code it's in a state of insanity to be honest (and it was even worse before 😅).

The test are failing apparently because of a python server error that I didn't touch, can you give me any help?

giulioz avatar Sep 15 '20 05:09 giulioz

Does it "compile" for you?

nicomazz avatar Sep 15 '20 08:09 nicomazz

image

I've just added serve for production file serving and it works fine form me.

giulioz avatar Sep 16 '20 10:09 giulioz