scapy icon indicating copy to clipboard operation
scapy copied to clipboard

Results.plot callback receive 2 args: (query,answer)

Open isidroas opened this issue 7 months ago • 1 comments

Fixes:

>>> a.plot(lambda x:x[1].id)
File /home/isidro/ms/webserver/venv/lib/python3.13/site-packages/scapy/plist.py:288, in _PacketList.plot(self, f, lfilter, plot_xy, **kargs)
    286 # Get the list of packets
    287 if lfilter is None:
--> 288     lst_pkts = [f(*e) for e in self.res]
    289 else:
    290     lst_pkts = [f(*e) for e in self.res if lfilter(*e)]

TypeError: <lambda>() takes 1 positional argument but 2 were given

Checklist:

  • [ ] If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • [ ] I squashed commits belonging together
  • [ ] I added unit tests or explained why they are not relevant
  • [ ] I executed the regression tests (using cd test && ./run_tests or tox)
  • [ ] If the PR is still not finished, please create a Draft Pull Request

isidroas avatar Jun 05 '25 12:06 isidroas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.26%. Comparing base (56de4f4) to head (e37679c). Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4764      +/-   ##
==========================================
- Coverage   82.16%   81.26%   -0.90%     
==========================================
  Files         362      363       +1     
  Lines       87359    88325     +966     
==========================================
+ Hits        71777    71780       +3     
- Misses      15582    16545     +963     

see 6 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 15 '25 04:06 codecov[bot]