Radius: Add timestamp attribute
Checklist:
- [x] If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
Recently I was using Scapy to parse and create some radius packets. I have noticed not all attributes are implemented in the radius module, more specifically it was lacking one very common attribute and so I decided to add it -> Event Timestamp. It is taken from RFC 2869.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.15%. Comparing base (
6c658dd) to head (738c08e). Report is 23 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #4759 +/- ##
==========================================
+ Coverage 79.52% 82.15% +2.63%
==========================================
Files 344 362 +18
Lines 87082 87361 +279
==========================================
+ Hits 69251 71775 +2524
+ Misses 17831 15586 -2245
| Files with missing lines | Coverage Δ | |
|---|---|---|
| scapy/layers/radius.py | 92.39% <100.00%> (+0.05%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Hi ! Thanks for the PR. Could you move it so that it's in incremental order compared to the others? Thanks
Hi ! Thanks for the PR. Could you move it so that it's in incremental order compared to the others? Thanks
Done:)
Thanks for the PR & sorry for the delay !