scapy icon indicating copy to clipboard operation
scapy copied to clipboard

Radius: Add timestamp attribute

Open TomBassa2004 opened this issue 7 months ago • 3 comments

Checklist:

  • [x] If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)

Recently I was using Scapy to parse and create some radius packets. I have noticed not all attributes are implemented in the radius module, more specifically it was lacking one very common attribute and so I decided to add it -> Event Timestamp. It is taken from RFC 2869.

TomBassa2004 avatar May 31 '25 10:05 TomBassa2004

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.15%. Comparing base (6c658dd) to head (738c08e). Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
+ Coverage   79.52%   82.15%   +2.63%     
==========================================
  Files         344      362      +18     
  Lines       87082    87361     +279     
==========================================
+ Hits        69251    71775    +2524     
+ Misses      17831    15586    -2245     
Files with missing lines Coverage Δ
scapy/layers/radius.py 92.39% <100.00%> (+0.05%) :arrow_up:

... and 288 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 01 '25 20:06 codecov[bot]

Hi ! Thanks for the PR. Could you move it so that it's in incremental order compared to the others? Thanks

gpotter2 avatar Jun 02 '25 06:06 gpotter2

Hi ! Thanks for the PR. Could you move it so that it's in incremental order compared to the others? Thanks

Done:)

TomBassa2004 avatar Jun 02 '25 10:06 TomBassa2004

Thanks for the PR & sorry for the delay !

gpotter2 avatar Jul 11 '25 11:07 gpotter2