scapy icon indicating copy to clipboard operation
scapy copied to clipboard

ci: skip the automotive_comm tests on Packit for now

Open evverx opened this issue 1 year ago • 1 comments

python3-can can't be installed on Rawhide due to https://bugzilla.redhat.com/show_bug.cgi?id=2315547.

I'll convert it to draft because another option would be to remove Rawhide from the packit config here and keep it in my fork. This way the CI should be less flaky here and it should still be possible for me to catch things popping up when the latest versions of its test/runtime dependencies are rolled out on Rawhide. The testing strategy is being discussed in https://github.com/packit/packit/discussions/2407#discussioncomment-10862405 so I'll try to figure out what would be better.

evverx avatar Oct 07 '24 00:10 evverx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.61%. Comparing base (93c9472) to head (2bcee63). Report is 31 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4562   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files         356      356           
  Lines       85544    85544           
=======================================
+ Hits        69818    69819    +1     
+ Misses      15726    15725    -1     

see 4 files with indirect coverage changes

codecov[bot] avatar Oct 07 '24 00:10 codecov[bot]

https://bugzilla.redhat.com/show_bug.cgi?id=2315547 was closed recently and to judge from https://download.copr.fedorainfracloud.org/results/packit/evverx-scapy-2/fedora-rawhide-aarch64/08469912-scapy/builder-live.log.gz this patch is no longer needed.

I think all in all it would maybe make sense to keep manual_trigger for the time being. (Though as far as I understand the Packit folks are OK with triggering it automatically).

evverx avatar Jan 04 '25 05:01 evverx