Match Netbios responses for hostnames over length 15
Scapy handles long netbios hostname queries by trimming the hostname to the maximum of 15 characters before sending the request. When a response is sent back, Scapy fails to match the response to the request because it matches the trimmed hostname against the full-length one originally requested.
This PR will trim the original hostname being queried when matching requests in answers.
This is referenced in issue #4443
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.46%. Comparing base (
a1afb9a) to head (59577a6). Report is 3 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #4446 +/- ##
==========================================
- Coverage 81.46% 81.46% -0.01%
==========================================
Files 353 353
Lines 84477 84481 +4
==========================================
- Hits 68822 68820 -2
- Misses 15655 15661 +6
| Files | Coverage Δ | |
|---|---|---|
| scapy/fields.py | 92.63% <100.00%> (+0.01%) |
:arrow_up: |
Hi, just wanted to check in and see if there's anything else needed on my end for this PR?