scapy icon indicating copy to clipboard operation
scapy copied to clipboard
verified publisher icon secdev

ISOTPNativeSocket improvements

Open polybassa opened this issue 1 year ago • 2 comments

This PR update the ISOTPNativeSocket to store all arguments as internal variables for easier serialization. Also some docstrings to SuperSockets are added

polybassa avatar Apr 25 '24 20:04 polybassa

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 82.20%. Comparing base (9dcee45) to head (8c6ad37).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4363      +/-   ##
==========================================
+ Coverage   81.48%   82.20%   +0.71%     
==========================================
  Files         353      353              
  Lines       83607    83618      +11     
==========================================
+ Hits        68130    68740     +610     
+ Misses      15477    14878     -599
Files Coverage Δ
scapy/contrib/isotp/isotp_soft_socket.py 85.50% <ø> (-0.19%) :arrow_down:
scapy/supersocket.py 73.68% <ø> (ø)
scapy/contrib/isotp/isotp_native_socket.py 41.17% <4.34%> (-2.22%) :arrow_down:

... and 18 files with indirect coverage changes

codecov[bot] avatar Apr 25 '24 20:04 codecov[bot]

@gpotter2 can this one get merged?

polybassa avatar May 09 '24 06:05 polybassa