scapy
scapy copied to clipboard
Fix endianess typo
fix typo endianess -> endianness
Codecov Report
Merging #4331 (cd44255) into master (f919a6a) will decrease coverage by
0.38%
. Report is 2 commits behind head on master. The diff coverage is100.00%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #4331 +/- ##
==========================================
- Coverage 81.67% 81.30% -0.38%
==========================================
Files 350 350
Lines 82884 82884
==========================================
- Hits 67699 67387 -312
- Misses 15185 15497 +312
Files | Coverage Δ | |
---|---|---|
scapy/contrib/pnio_rpc.py | 94.67% <100.00%> (ø) |
|
scapy/contrib/rtps/common_types.py | 95.27% <100.00%> (ø) |
|
scapy/layers/dcerpc.py | 90.90% <100.00%> (ø) |
I have mixed feelings about this.
On the one hand this is technically correct, on the other I have mixed feelings merging a PR that's part of a 47 batch that only fixes a typo on the word "endianness". That's.. almost spammy, and reminds me of what people did to get PRs in for Hacktoberfest (or similar contests).
What are you doing that for ? or what's the big deal with endianness :p
I have mixed feelings about this.
On the one hand this is technically correct, on the other I have mixed feelings merging a PR that's part of a 47 batch that only fixes a typo on the word "endianness".
@gpotter2 Thank you for your review. There are also functional and other changes in my PRs.
That's.. almost spammy, and reminds me of what people did to get PRs in for Hacktoberfest (or similar contests).
What are you doing that for ? or what's the big deal with endianness :p
Its no contest, no medal hunt.
Its a test + dev of a bot that prepares everything up to the pull request. The review and PR is done manually by me.
The endianess
is only used as an test case: an unique and often made typo easy to find and to fix.
So I learn much about the big reops, PR formatting, code style and so on.
Why not? This is what bots are made for. ;)
Greetings