scapy
scapy copied to clipboard
bluetooth: Add some EIR fields
Checklist:
- [x] If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
- [x] I squashed commits belonging together
- [x] I added unit tests or explained why they are not relevant
- [x] I executed the regression tests (using
cd test && ./run_tests
ortox
) - [x] If the PR is still not finished, please create a Draft Pull Request
Bluetooth EIR packets.
Added few tests as I could not find data samples that I could share. I will try to collect some real world examples I can put there.
Codecov Report
Merging #4273 (e95d088) into master (0a2b2bc) will increase coverage by
0.01%
. The diff coverage is95.23%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #4273 +/- ##
==========================================
+ Coverage 82.03% 82.04% +0.01%
==========================================
Files 350 350
Lines 82888 82929 +41
==========================================
+ Hits 67994 68036 +42
+ Misses 14894 14893 -1
Files | Coverage Δ | |
---|---|---|
scapy/fields.py | 92.39% <100.00%> (ø) |
|
scapy/layers/bluetooth.py | 89.81% <95.12%> (+0.21%) |
:arrow_up: |
As said previously, it is not easy to find those fields out in the wild to test this as acuratelly as possible...
I will add tests as soon as I come across a packet for the missing packets. For the time being I would like to merge the tested packets if possible. I can remove the untested packets from the PR if you wish so...
Thanks!
Would you prefer that I delete the non-tested packets or to leave them? Thanks