scapy icon indicating copy to clipboard operation
scapy copied to clipboard

fix SOMEIP answers function, in case there is SD above

Open geynis opened this issue 2 years ago • 2 comments

Checklist:

  • [V] If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • [V] I squashed commits belonging together
  • [] I added unit tests or explained why they are not relevant
  • [ ] I executed the regression tests (using cd test && ./run_tests or tox)
  • [ ] If the PR is still not finished, please create a Draft Pull Request

This fixes a bug in the answers function of SOMEIP, in case there is a SD above it. it should be considered.

fixes #xxx

geynis avatar Jul 10 '23 07:07 geynis

Thanks for your PR. Could you please add a unit test for this case?

polybassa avatar Jul 10 '23 08:07 polybassa

Codecov Report

Merging #4061 (54c5599) into master (6dbdc37) will decrease coverage by 0.01%. Report is 199 commits behind head on master. The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4061      +/-   ##
==========================================
- Coverage   81.95%   81.94%   -0.01%     
==========================================
  Files         327      327              
  Lines       75540    75542       +2     
==========================================
- Hits        61911    61906       -5     
- Misses      13629    13636       +7     
Files Coverage Δ
scapy/contrib/automotive/someip.py 92.92% <0.00%> (-0.83%) :arrow_down:

... and 4 files with indirect coverage changes

codecov[bot] avatar Jul 10 '23 08:07 codecov[bot]