scapy icon indicating copy to clipboard operation
scapy copied to clipboard

Parse PAC from kerberos tickets

Open gpotter2 opened this issue 3 years ago • 1 comments

  • parse & build the PAC from kerberos tickets
  • adds an IRL test for our NDR engine (because parts of [MS-PAC] use [MS-RPCE] marshalling)

gpotter2 avatar Sep 15 '22 18:09 gpotter2

Codecov Report

Merging #3738 (850fc36) into master (799f272) will increase coverage by 0.05%. The diff coverage is 90.95%.

@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
+ Coverage   86.00%   86.05%   +0.05%     
==========================================
  Files         299      300       +1     
  Lines       68111    68304     +193     
==========================================
+ Hits        58579    58780     +201     
+ Misses       9532     9524       -8     
Impacted Files Coverage Δ
scapy/config.py 80.55% <ø> (ø)
scapy/layers/kerberos.py 70.93% <66.66%> (+1.02%) :arrow_up:
scapy/layers/dcerpc.py 78.62% <79.31%> (+1.88%) :arrow_up:
scapy/layers/mspac.py 93.67% <93.67%> (ø)
scapy/packet.py 82.67% <100.00%> (ø)
scapy/arch/windows/__init__.py 67.16% <0.00%> (-0.56%) :arrow_down:
scapy/pipetool.py 84.10% <0.00%> (-0.23%) :arrow_down:
scapy/fields.py 91.34% <0.00%> (+0.53%) :arrow_up:

codecov[bot] avatar Sep 15 '22 18:09 codecov[bot]

Actually @gpotter2 I had a question you did not answer, that's why I did not merge that PR.

p-l- avatar Sep 28 '22 06:09 p-l-

Oh sorry about that, do you have something in mind? I'm still actively changing things here

gpotter2 avatar Sep 28 '22 07:09 gpotter2

Yes, I think you should create _PACTYPES at the end with all the values at once, rather than populating it. It makes fewer accesses (even though that's hardly significant).

p-l- avatar Sep 28 '22 14:09 p-l-