scapy icon indicating copy to clipboard operation
scapy copied to clipboard

Published 20 hours ago • verified publisher icon secdev

E275 - Missing whitespace after keyword

Open polybassa opened this issue 2 years ago • 9 comments

polybassa avatar Aug 06 '22 06:08 polybassa

I've applied some regex based replacements. Let's see if it smokes.

polybassa avatar Aug 06 '22 06:08 polybassa

Codecov Report

Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage by 0.00%. The diff coverage is 86.77%.

:exclamation: Current head 87543f1 differs from pull request most recent head 6f0c067. Consider uploading reports for the commit 6f0c067 to get more accurate results

@@           Coverage Diff           @@
##           master    #3711   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files         296      296           
  Lines       67240    67240           
=======================================
+ Hits        57905    57906    +1     
+ Misses       9335     9334    -1
Impacted Files Coverage Δ
scapy/asn1/mib.py 90.72% <0.00%> (ø)
scapy/layers/http.py 77.29% <0.00%> (ø)
scapy/layers/ntlm.py 44.76% <0.00%> (ø)
scapy/layers/x509.py 91.99% <0.00%> (ø)
scapy/supersocket.py 60.36% <50.00%> (+0.30%) :arrow_up:
scapy/main.py 74.39% <60.00%> (ø)
scapy/arch/windows/structures.py 89.81% <66.66%> (ø)
scapy/contrib/pnio.py 83.76% <66.66%> (ø)
scapy/layers/inet6.py 88.23% <66.66%> (ø)
scapy/packet.py 82.65% <66.66%> (ø)
... and 25 more

codecov[bot] avatar Aug 06 '22 08:08 codecov[bot]

Thanks! What is the error message or the PEP number that this PR is fixing ? It could be relevant to reflect it in the commit message

Sent from my iPhone

On 6 Aug 2022, at 10:05, codecov[bot] @.***> wrote:  Codecov Report

Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage by 0.00%. The diff coverage is 86.77%.

@@ Coverage Diff @@

master #3711 +/-

======================================= Coverage 86.11% 86.11%

Files 296 296
Lines 67240 67240

  • Hits 57905 57906 +1
  • Misses 9335 9334 -1
    Impacted Files Coverage Δ scapy/asn1/mib.py 90.72% <0.00%> (ø) scapy/layers/http.py 77.29% <0.00%> (ø) scapy/layers/ntlm.py 44.76% <0.00%> (ø) scapy/layers/x509.py 91.99% <0.00%> (ø) scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️ scapy/main.py 74.39% <60.00%> (ø) scapy/arch/windows/structures.py 89.81% <66.66%> (ø) scapy/contrib/pnio.py 83.76% <66.66%> (ø) scapy/layers/inet6.py 88.23% <66.66%> (ø) scapy/packet.py 82.65% <66.66%> (ø) ... and 25 more — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

guedou avatar Aug 06 '22 08:08 guedou

E275

Viele Grüße

Nils Weiß

On August 6, 2022 10:37:02 AM GMT+02:00, Guillaume Valadon @.***> wrote:

Thanks! What is the error message or the PEP number that this PR is fixing ?> It could be relevant to reflect it in the commit message>

Sent from my iPhone>

On 6 Aug 2022, at 10:05, codecov[bot] @.***> wrote:> > Codecov Report>

Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage by 0.00%.> The diff coverage is 86.77%.>

@@ Coverage Diff @@>

master #3711 +/- ##>

=======================================> Coverage 86.11% 86.11% > =======================================> Files 296 296 > Lines 67240 67240 > =======================================>

  • Hits 57905 57906 +1 >
  • Misses 9335 9334 -1 > Impacted Files Coverage Δ > scapy/asn1/mib.py 90.72% <0.00%> (ø) > scapy/layers/http.py 77.29% <0.00%> (ø) > scapy/layers/ntlm.py 44.76% <0.00%> (ø) > scapy/layers/x509.py 91.99% <0.00%> (ø) > scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️> scapy/main.py 74.39% <60.00%> (ø) > scapy/arch/windows/structures.py 89.81% <66.66%> (ø) > scapy/contrib/pnio.py 83.76% <66.66%> (ø) > scapy/layers/inet6.py 88.23% <66.66%> (ø) > scapy/packet.py 82.65% <66.66%> (ø) > ... and 25 more > —> Reply to this email directly, view it on GitHub, or unsubscribe.> You are receiving this because you are subscribed to this thread.>

-- > Reply to this email directly or view it on GitHub:> https://github.com/secdev/scapy/pull/3711#issuecomment-1207175282> You are receiving this because you authored the thread.>

Message ID: @.***>

polybassa avatar Aug 06 '22 09:08 polybassa

A good example if commit message for this kind of change is https://github.com/secdev/scapy/pull/1612

Could you also add the Co-Author-by to reflect the latest author of the line that this PR is modifying?

I know that this is a bit complicated but these as the rules that we defined in https://github.com/secdev/scapy/issues/1277

Thanks

Sent from my iPhone

On 6 Aug 2022, at 11:19, Nils Weiss @.***> wrote:

 E275

Viele Grüße

Nils Weiß

On August 6, 2022 10:37:02 AM GMT+02:00, Guillaume Valadon @.***> wrote:

Thanks! What is the error message or the PEP number that this PR is fixing ?> It could be relevant to reflect it in the commit message>

Sent from my iPhone>

On 6 Aug 2022, at 10:05, codecov[bot] @.***> wrote:> > Codecov Report>

Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage by 0.00%.> The diff coverage is 86.77%.>

@@ Coverage Diff @@>

master #3711 +/- ##>

=======================================> Coverage 86.11% 86.11% > =======================================> Files 296 296 > Lines 67240 67240 > =======================================>

  • Hits 57905 57906 +1 >
  • Misses 9335 9334 -1 > Impacted Files Coverage Δ > scapy/asn1/mib.py 90.72% <0.00%> (ø) > scapy/layers/http.py 77.29% <0.00%> (ø) > scapy/layers/ntlm.py 44.76% <0.00%> (ø) > scapy/layers/x509.py 91.99% <0.00%> (ø) > scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️> scapy/main.py 74.39% <60.00%> (ø) > scapy/arch/windows/structures.py 89.81% <66.66%> (ø) > scapy/contrib/pnio.py 83.76% <66.66%> (ø) > scapy/layers/inet6.py 88.23% <66.66%> (ø) > scapy/packet.py 82.65% <66.66%> (ø) > ... and 25 more > —> Reply to this email directly, view it on GitHub, or unsubscribe.> You are receiving this because you are subscribed to this thread.>

-- > Reply to this email directly or view it on GitHub:> https://github.com/secdev/scapy/pull/3711#issuecomment-1207175282> You are receiving this because you authored the thread.>

Message ID: @.***> — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

guedou avatar Aug 06 '22 10:08 guedou

Phuu .. do you have a handy git blame command to obtain that information?

Viele Grüße

Nils Weiß

On August 6, 2022 12:04:33 PM GMT+02:00, Guillaume Valadon @.***> wrote:

A good example if commit message for this kind of change is https://github.com/secdev/scapy/pull/1612>

Could you also add the Co-Author-by to reflect the latest author of the line that this PR is modifying?>

I know that this is a bit complicated but these as the rules that we defined in https://github.com/secdev/scapy/issues/1277>

Thanks >

Sent from my iPhone>

On 6 Aug 2022, at 11:19, Nils Weiss @.***> wrote:>

> E275> -- > Viele Grüße>

Nils Weiß>

On August 6, 2022 10:37:02 AM GMT+02:00, Guillaume Valadon @.***> wrote:>

Thanks! What is the error message or the PEP number that this PR is> fixing ?>> It could be relevant to reflect it in the commit message>>

Sent from my iPhone>>

On 6 Aug 2022, at 10:05, codecov[bot] @.***> wrote:>> >> Codecov Report>>

Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage> by 0.00%.>> The diff coverage is 86.77%.>>

@@ Coverage Diff @@>>

master #3711 +/- ##>>

=======================================>> Coverage 86.11% 86.11% >> =======================================>> Files 296 296 >> Lines 67240 67240 >> =======================================>>

  • Hits 57905 57906 +1 >>
  • Misses 9335 9334 -1 >> Impacted Files Coverage Δ >> scapy/asn1/mib.py 90.72% <0.00%> (ø) >> scapy/layers/http.py 77.29% <0.00%> (ø) >> scapy/layers/ntlm.py 44.76% <0.00%> (ø) >> scapy/layers/x509.py 91.99% <0.00%> (ø) >> scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️>> scapy/main.py 74.39% <60.00%> (ø) >> scapy/arch/windows/structures.py 89.81% <66.66%> (ø) >> scapy/contrib/pnio.py 83.76% <66.66%> (ø) >> scapy/layers/inet6.py 88.23% <66.66%> (ø) >> scapy/packet.py 82.65% <66.66%> (ø) >> ... and 25 more >> —>> Reply to this email directly, view it on GitHub, or unsubscribe.>> You are receiving this because you are subscribed to this thread.>>

-- >> Reply to this email directly or view it on GitHub:>> https://github.com/secdev/scapy/pull/3711#issuecomment-1207175282>> You are receiving this because you authored the thread.>>

Message ID: @.***>> —> Reply to this email directly, view it on GitHub, or unsubscribe.> You are receiving this because you commented.>

-- > Reply to this email directly or view it on GitHub:> https://github.com/secdev/scapy/pull/3711#issuecomment-1207186997> You are receiving this because you authored the thread.>

Message ID: @.***>

polybassa avatar Aug 06 '22 13:08 polybassa

Added all the Co-Authors

polybassa avatar Aug 06 '22 18:08 polybassa

I usually do:

flake8 --select=E20 scapy/ > lines.txt
bash pepin.sh > co-authored-by.txt

pepin.sh.txt

guedou avatar Aug 07 '22 16:08 guedou

Thanks. Good to know for next time

Viele Grüße

Nils Weiß

On August 7, 2022 6:07:48 PM GMT+02:00, Guillaume Valadon @.***> wrote:

I usually do:

flake8 --select=E20 scapy/ > lines.txt
bash pepin.sh > co-authored-by.txt

pepin.sh.txt

-- Reply to this email directly or view it on GitHub: https://github.com/secdev/scapy/pull/3711#issuecomment-1207438777 You are receiving this because you modified the open/close state.

Message ID: @.***>

polybassa avatar Aug 07 '22 16:08 polybassa

Thanks a lot for doing this polybassa !

gpotter2 avatar Aug 10 '22 16:08 gpotter2

You are welcome. Thanks to my IDE for search and replace ;-)

On August 10, 2022 6:08:18 PM GMT+02:00, gpotter2 @.***> wrote:

Thanks a lot for doing this polybassa !

-- Reply to this email directly or view it on GitHub: https://github.com/secdev/scapy/pull/3711#issuecomment-1210930536 You are receiving this because you modified the open/close state.

Message ID: @.***>

polybassa avatar Aug 10 '22 16:08 polybassa