scapy icon indicating copy to clipboard operation
scapy copied to clipboard

Add STUN Support

Open oborichkin opened this issue 3 years ago • 0 comments

  • Added basic support for Binding method of STUN (RFC 3489).
  • Added attributes:
    • USERNAME
    • MESSAGE-INTEGRITY
    • XOR-MAPPED-ADDRESS
    • USE-CANDIDATE
    • PRIORITY
    • FINGERPRINT
    • ICE-CONTROLLING
    • GOOG-NETWORK-INFO

oborichkin avatar Aug 04 '22 13:08 oborichkin

Hi @Oborichkin! Could you please rebase against current master for the CI tests?

p-l- avatar Aug 10 '22 11:08 p-l-

Hi @p-l- !

Could you please rebase against current master for the CI tests?

done!

oborichkin avatar Aug 11 '22 23:08 oborichkin

This PR seems to break some of the tests (apparently Python 2). Could you have a look?

p-l- avatar Aug 12 '22 11:08 p-l-

Can you make it RFC8489 compliant?

jkldgoefgkljefogeg avatar Aug 12 '22 22:08 jkldgoefgkljefogeg

Codecov Report

Merging #3709 (d02228b) into master (75269fc) will increase coverage by 0.00%. The diff coverage is 82.05%.

@@           Coverage Diff           @@
##           master    #3709   +/-   ##
=======================================
  Coverage   86.07%   86.08%           
=======================================
  Files         298      299    +1     
  Lines       67942    68020   +78     
=======================================
+ Hits        58484    58552   +68     
- Misses       9458     9468   +10     
Impacted Files Coverage Δ
scapy/contrib/stun.py 82.05% <82.05%> (ø)
scapy/arch/windows/__init__.py 67.73% <0.00%> (-0.57%) :arrow_down:
scapy/fields.py 90.85% <0.00%> (+0.05%) :arrow_up:
scapy/automaton.py 74.12% <0.00%> (+0.11%) :arrow_up:
scapy/layers/ntp.py 84.82% <0.00%> (+0.27%) :arrow_up:
scapy/supersocket.py 60.36% <0.00%> (+0.30%) :arrow_up:
scapy/layers/l2.py 76.71% <0.00%> (+0.68%) :arrow_up:

codecov[bot] avatar Aug 27 '22 17:08 codecov[bot]

This PR seems to break some of the tests (apparently Python 2). Could you have a look?

Yep, done

oborichkin avatar Aug 27 '22 18:08 oborichkin

Can you make it RFC8489 compliant?

Oops, wrote a wrong RFC number in PR. It is RFC 8489 compliant

oborichkin avatar Aug 27 '22 19:08 oborichkin