libseccomp-golang icon indicating copy to clipboard operation
libseccomp-golang copied to clipboard

RFE: golang: add missing architectures

Open kolyshkin opened this issue 1 year ago • 7 comments

Add a few more missing architectures:

  • LOONG64
  • M68K
  • SH and SHEB

kolyshkin avatar Mar 09 '23 18:03 kolyshkin

@kolyshkin Hi kolyshkin, I'm very sorry, maybe my understanding is wrong, it is mentioned in this PR that ArchLOONGARCH64 should be used. In the libseccomp-go project, how do you understand this problem.

zhaixiaojuan avatar Mar 17 '23 03:03 zhaixiaojuan

@kolyshkin Hi kolyshkin, I'm very sorry, maybe my understanding is wrong, it is mentioned in this PR that ArchLOONGARCH64 should be used. In the libseccomp-go project, how do you understand this problem.

Reworked to put the "ARCH" suffix back. It is now LOONGARCH64 everywhere.

kolyshkin avatar Mar 31 '23 00:03 kolyshkin

What's current status?

AkihiroSuda avatar Sep 26 '23 12:09 AkihiroSuda

@kolyshkin Hi kolyshkin, Could you consider merging this PR?

zhaixiaojuan avatar Oct 13 '23 02:10 zhaixiaojuan

What's current status?

znley avatar May 08 '24 03:05 znley

@drakenclimber @pcmoore PTAL

kolyshkin avatar May 09 '24 15:05 kolyshkin

Looks good to me.

Acked-by: Paul Moore <[email protected]>

pcmoore avatar May 09 '24 23:05 pcmoore