SDVersion DeviceSize should contain iPad sizes too!

DeviceSize should contain iPad sizes too!

Open revolter opened this issue 7 years ago • 3 comments

There's no reason why DeviceSize wouldn't have the iPad sizes too (9.7 and 12.9). If not, then it should be named iPhoneDeviceSize.

Aug 17 '17 13:08 revolter

@sebyddd any progress on this issue?

May 03 '18 08:05 filletofish

This would be awesome. Idea for use in interface builder in preview. When using drawing code.

Aug 16 '18 22:08 JulesMoorhouse

I've added a PR for this https://github.com/sebyddd/SDVersion/pull/87 This also include simulator support for iPads from another PR.

You can use this in your podfile like so...

pod 'SDVersion', :git => 'https://github.com/Jules2010/SDVersion', :inhibit_warnings => true , :commit => '17b66e586cf555c95a307ce0cbb24952c3e3f91c'

Aug 17 '18 07:08 JulesMoorhouse