Shaarli icon indicating copy to clipboard operation
Shaarli copied to clipboard

LDAP auth

Open meutel opened this issue 10 years ago • 2 comments

Adds simple LDAP authentification. Uses additional config: auth_backend: use "LDAP" to active LDAP authentification ldaphost: LDAP server hostname ldapport: LDAP server port ldaprdntpl: user RDN template (%login% replaced by actual login), example: uid=%login%,ou=people,dc=example,dc=org

meutel avatar Nov 23 '14 10:11 meutel

Hi meutel, thanks for the pull request. At this moment we are waiting on @sebsauvage to become active again, and we are working on a temporary community fork where a number of fixes and improvements have already been merged. the idea is to merge the community fork back into Seb's main project, or switch the project structure to a community-based model. In any case, I'd encourage you to submit this pull request against that fork as well: https://github.com/shaarli/Shaarli

Looking through your pull request, I have made a couple of comments inline (in the Files Changed tab). ~~It's the first time I'm using this Github functionality, let me know if you don't see my comments and I'll add them in this discussion.~~ Looks like they are added automatically ;)

This functionality requires the presence of multiple configuration values. To prevent future issues being logged of the type "LDAP doesn't work" that would be due to the user not reading the source code closely enough (which we can't really expect) and missing one of the parameters, I suggest you add these parameters in the GUI configuration part. If you need an example, look at the changes made to tpl/configure.html and $GLOBALS in index.php in this pull request.

Thanks for your work on Shaarli.

e2jk avatar Nov 23 '14 13:11 e2jk

Hi there !

Sorry to dig up this old pull request, but has any work been done to make this pull request on the community's repository (I could not find it)?

Would any of you know if this PR could be taken as a base or if the codebase changed too much and this PR's code is now stale?

Thanks in advance, I think it would be really nice to have this (in particular with the YunoHost package of Shaarli if you know YNH).

nicofrand avatar Mar 08 '19 09:03 nicofrand