Sergey G. Brester

Results 533 comments of Sergey G. Brester

> I'm assuming 2.7 support is required It does not. You can skip the TLS test for 2.7 (and a fallback to smtpd_tls as also OK to me). Otherwise we...

I would use this one either: ```regex ... (?:\(X-Forwarded-For: [^\)]+\)\s+)?... ``` 1. specified after the space it wouldn't necessarily enter a new (optional) branch on mandatory space after the address,...

The issie with this approach (ignoring forwarded address) is - it would depend how exactly the proxies are configured (or whether the proxying address is interesting) or what exactly one...

Well basically it would be enough to overwrite `prefregex` (and leave `failregex` unmodified), PoC: ```bash $ msg='Feb 2 16:32:10 srv froxlor[30442]: froxlor.WARNING: User usr tried to login with wrong password....

> How is it assured, that defined filters work for different versions Well, either it could be made configurable, so the `prefregex` would change depending some parameter. Or since the...

> and user which is either the loginname or the ip address if loginname is unknown to the system So it is important to clarify the question, what would happen...

Well, this was not a requirement, either it is more a recommendation (or even just a note by the way).

> Also, another magic: what did you do that the test now passes? Was it related to `prefix_line`? Our test-suite is running in "Aug 14 10:00:00 GMT 2005" and your...

You can not use 0.10 as target branch without rebase your PR branch to 0.10 too, thus I changed the base of PR to 0.11. It can be rebased if...

Do you have an example log-line this filter should match?