art icon indicating copy to clipboard operation
art copied to clipboard

Check if `this` is defined

Open f0rr0 opened this issue 8 years ago • 11 comments

f0rr0 avatar May 11 '17 06:05 f0rr0

@sebmarkbage This needs to be merged.

IgorBelyayev avatar Jan 05 '18 09:01 IgorBelyayev

@sebmarkbage Yes, this needs to be merged ASAP!

Tredis avatar Jan 05 '18 09:01 Tredis

I'm running into this issue as well with babel+webpack. Anyone have a work around?

d4l3k avatar Jan 29 '18 00:01 d4l3k

Turns out you can just exclude this from babel and it works just fine.

      {
        test: /\.js?$/,
        loader: 'babel-loader',
        exclude: /node_modules\/art/,
        query: {
          presets: [
            ['env', {
              loose: true
            }],
            'react'
          ],
          plugins: [
            'transform-object-rest-spread',
            'transform-class-properties'
          ]
        }
      }

d4l3k avatar Jan 29 '18 01:01 d4l3k

Can this be merged? Also, what workaround can be used if not using Webpack, only Babel?

piranna avatar May 18 '18 19:05 piranna

Should be able to exclude certain files using .babelrc. https://stackoverflow.com/questions/35415301/make-babel-exclude-test-files

d4l3k avatar May 18 '18 19:05 d4l3k

Should be able to exclude certain files using .babelrc. https://stackoverflow.com/questions/35415301/make-babel-exclude-test-files

Yeah, but was not able to make it work. Anyway, I tried what's done on this pull-request and tests are passing, that's the only thing I wanted, so it's ok for me for now, but definitely this should be merged.

piranna avatar May 18 '18 20:05 piranna

this should be merged

relign avatar Feb 26 '19 07:02 relign

Please merge this ASAP!

john-angelogiannis avatar Mar 06 '19 13:03 john-angelogiannis

Can we please merge this?

bing107 avatar Mar 06 '19 13:03 bing107

Can we please merge this?

timwuhaotian avatar Apr 02 '19 03:04 timwuhaotian