cops icon indicating copy to clipboard operation
cops copied to clipboard
verified publisher icon seblucas

Feature: Change monocle to epub.js

Open s-fiebig opened this issue 6 years ago • 8 comments

The monocle package is currently not developed anymore and I don't know of any "serious" fork continuing work. epub.js (https://github.com/futurepress/epub.js) seems like a good choice to allow in-browser reading, which is still actively developed. In addition, the current monocle reader is not a good choice for reading graphical novels, e.g. comics or mangas, with full page images. In my cases, the images render offscreen and scrolling is not even possible. Instead of fixing this issue in monocle, I've implemented epub.js locally for testing purposes and it looks very promising.

Would there be any interest to include a pull request using a epub.js. In this case I'd rework my local prototype and create some setting to switch between both readers.

s-fiebig avatar Sep 14 '19 17:09 s-fiebig

I would love to see that implemented, even if as a switch function

horus68 avatar Sep 17 '19 10:09 horus68

That's great to know! I'm preparing a pull request, so that somebody can have a look what features of epub.js should be included in addition. The sample reader https://github.com/futurepress/epubjs-reader does not implement all the nice features that are possible.

s-fiebig avatar Oct 01 '19 17:10 s-fiebig

@seblucas @marioscube

horus68 avatar Oct 01 '19 20:10 horus68

@s-fiebig please send a PR, it's on my todo list for a while ;)

seblucas avatar Oct 13 '19 10:10 seblucas

I haven't forgotten about this issue ;-). But some personal life issues came up that made it impossible to work on it for the last two weeks. But maybe I can talk about some of my last items I wanted to resolve for the PR:

  • I'm not sure what to do about localization for the single setting item I introduced. I can add German and English with confidence. What to do about the others? Machine translation and somebody improves it later?
  • The current fullscreen mode for epub.js reader project (this is unrelated to the epub.js library itself) does not work correctly. Especially mobile devices have "problems" with fullscreen mode. I wanted to have a solution for this.
  • In addition, the features font size and continuous scrolling have been on my wishlist for a first version.

s-fiebig avatar Oct 13 '19 14:10 s-fiebig

For the translations: you create the English file on your PR. Than i will upload that file to the Transifex Translations system here: http://www.transifex.com/rberec/cops From there COPS users can translate it to their languages. I will then submit the translations into a new PR to Cops github just for the translations done.

horus68 avatar Oct 13 '19 15:10 horus68

@s-fiebig No rush take all the time you need, still if you want to make an early PR, please do it so it will be easier for others to help/test

seblucas avatar Oct 13 '19 18:10 seblucas