mundus icon indicating copy to clipboard operation
mundus copied to clipboard

Add more locations for Eclipse

Open gim- opened this issue 8 years ago • 3 comments

gim- avatar Jun 24 '16 16:06 gim-

Thanks for the PR! The only thing I would mention is the spelling mistake on submodule 1. What I'm worried about is that submodules 3, 5 and 6 seem too generic, and dangerous to be included as being specific to Eclipse. Would you consider removing them? I prefer to leave some trash files on users computers than to let them accidentally delete a directory not belonging to the application they thought created it.

sebikul avatar Jun 25 '16 00:06 sebikul

@sebikul It's a really bad design decision on Eclipse part to name directories this way, though Eclipse seems to be the only application that I know of to use such generic directory names inside ~/.config, but who knows. Maybe there is a way to inform users that some garbage still might be left in their home directory so that they can examine and remove it manually if needed? It's just sometimes Eclipse might misbehave and the only way to solve that is to completely remove everything, though as you can see it creates files all over the place and manually searching them is a tedious process, so your awesome application might come in handy for this.

gim- avatar Jun 25 '16 08:06 gim-

I understand. There is nothing implemented yet to notify users about those files being left on purpose, so I will see what I can do to add this feature. In the meantime, I really think it is unsafe to include those submodules I mentioned.

Please consider opening a separate bug report mentioning this feature, and the problematic submodules, so that once it is done we can quickly add it to the Eclipse module. This way, we can merge this PR right away, and postpone the remaining modifications.

sebikul avatar Jun 28 '16 22:06 sebikul