angular-google-maps icon indicating copy to clipboard operation
angular-google-maps copied to clipboard

build: upgrade to ng 14

Open yharaskrik opened this issue 2 years ago • 9 comments

Updates packages to Angular v14 (will be backwards compatible).

This update should work for Angular 9, 10, 11, 12, 13 and 14

Resolves: #2008, #2000, #1993, #1987, #1956, #1932, #1938, #1942

yharaskrik avatar Jun 06 '22 23:06 yharaskrik

@SebastianM hey there, merging and releasing a new major version would be much appreciated!

npm ERR! While resolving: @agm/[email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~12.2.6" from the root project
npm ERR!   peer @angular/common@"12.2.6" from @angular/[email protected]
npm ERR!   node_modules/@angular/forms
npm ERR!     @angular/forms@"~12.2.6" from the root project
npm ERR!   9 more (@angular/platform-browser, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^6.0.0 || ^7.0.0 || ^8.0.0" from @agm/[email protected]
npm ERR! node_modules/@agm/core
npm ERR!   @agm/core@"^1.1.0" from the root project

@angular/common 8.0 is a wee old, isn't it?

vitkarpov avatar Jun 09 '22 10:06 vitkarpov

Hi,

I'm also desperate for this merge.

Many thanks Jose Coelho

jmjcoelho avatar Jun 13 '22 15:06 jmjcoelho

@SebastianM Is there any chance that this pull will be approved and merged?

aston-r avatar Jun 13 '22 16:06 aston-r

Like probably most here, I’m stuck between a rock and a hard place. capacitor/google-maps is not working on iOS and @agm is not working with angular 12 ;( While we’re waiting for the merge would it be able to install the branch of Jay Bell? I’ve tried several approaches installing the branch via NPM or via the dependencies in package.json but I’ve not been successful. @yharaskrik could you provide some hints on how to achieve that as a temporary solution?

psmeets avatar Jun 13 '22 17:06 psmeets

@psmeets I created a fork of agm https://github.com/ng-maps/ng-maps Maybe this could also help. Although I don't have a lot of time for maintaining it I can manage to release updates along with new angular versions. Most of the API is the same as with agm.

DaSchTour avatar Jun 13 '22 18:06 DaSchTour

Because I wasn't sure if this was going to get merged or not I created a simple (very small) package to do places autocomplete on a form field if that is what you were using it for.

https://www.npmjs.com/package/@trellisorg/google-places-autocomplete

yharaskrik avatar Jun 13 '22 18:06 yharaskrik

@yharaskrik Thx for your quick reply and clarification, my use case is different @DaSchTour Thx for your suggestion, it will be the next thing to try if merging is not going forward..

psmeets avatar Jun 13 '22 20:06 psmeets

Is this moving forward? 😞 We can't upgrade to Angular 12+ because of dependencies issues.. and thank you @yharaskrik for trying to fix this! Update: could we use

npm install @angular/google-maps
import { GoogleMapsModule } from '@angular/google-maps';

instead?

@angular/google-maps seems to have a similar api

itayperry avatar Jul 18 '22 10:07 itayperry

@itayperry you can check https://github.com/ng-maps/ng-maps which is a fork of this project and should support everything agm supports.

DaSchTour avatar Jul 18 '22 16:07 DaSchTour

Hi! Since the angular 14 update for angular-google-maps was done and the last release (1.1.0) was quite long ago (July 20, 2020), I wonder when there will be a new release that contains the changes? Any plans? I would appreciate it. Thanks! @yharaskrik @sebholstein

Bernhard-Steindl avatar Jul 13 '23 15:07 Bernhard-Steindl