systeminformation icon indicating copy to clipboard operation
systeminformation copied to clipboard

Published 20 hours ago • verified publisher icon sebhildebrandt

Parse Bluetooth vendor IDs

Open schontz opened this issue 1 year ago • 6 comments

Fixes #783

schontz avatar Mar 10 '23 21:03 schontz

This still falls back to device_name for manufacturer. I'd suggest we don't use that as fallback because it could accidentally contain PII. For apps that are trying to remove PII when logging, they do not expect PII to be found in a manufacturer field.

schontz avatar Mar 10 '23 22:03 schontz

@schontz ... THANK YOU David! I need to have a closer look. As posted yesterday I also started to work on a fix for that. I also need to test the resulting fix on several machines. Will come back as soon as I have finished it.

sebhildebrandt avatar Mar 11 '23 10:03 sebhildebrandt

Sounds good. I only tested on my machine, so this will obviously need a broader test.

schontz avatar Mar 13 '23 16:03 schontz

@schontz SORRY! Still did not had time to test all of it but I hope I get some free time slot beginning of next week.

sebhildebrandt avatar Jun 28 '23 17:06 sebhildebrandt

No apologies necessary. For what it's worth, I've been running with a patched version of this without any issue, so it at least isn't breaking things.

schontz avatar Jun 28 '23 17:06 schontz

@schontz yes, but you spend your time on this nice patch!! I really appreciate it!

sebhildebrandt avatar Jun 28 '23 18:06 sebhildebrandt