systeminformation icon indicating copy to clipboard operation
systeminformation copied to clipboard

refactor: windows audio

Open OmgImAlexis opened this issue 2 years ago • 4 comments

This converts the module to use ConvertTo-Json in it's powershell commands making the code way more manageable.

The other thing I noticed is this should be faster since before you had to scan the whole stdout for every line. Now we just use the object it returns.

OmgImAlexis avatar Nov 13 '21 19:11 OmgImAlexis

@OmgImAlexis ... just to avoid, that we are doing the same thing. I also did this for most of the windows functions...

sebhildebrandt avatar Nov 13 '21 20:11 sebhildebrandt

I mean I've kinda been waiting over a month now. Like I keep saying this would go a lot faster to let me help. Instead I've been sitting here waiting for you to work on things without pushing changes frequently. Honestly I feel it'd be faster if I just forked at this point. 😞

OmgImAlexis avatar Nov 13 '21 20:11 OmgImAlexis

@sebhildebrandt can you either push your changes or accept this? Just waiting around is kinda getting to me.

OmgImAlexis avatar Nov 13 '21 20:11 OmgImAlexis

@sebhildebrandt any update on this?

OmgImAlexis avatar Nov 14 '21 19:11 OmgImAlexis