Sébastien HEITZMANN

Results 25 comments of Sébastien HEITZMANN

https://github.com/thomasjungblut/go-sstables/blob/d00463f192d4d4126a04a6ac66aa18fd26f44995/sstables/sstable_iterator.go#L70 Or maybe define a new KeyIterator

https://github.com/thomasjungblut/go-sstables/blob/d00463f192d4d4126a04a6ac66aa18fd26f44995/sstables/proto/sstable.proto#L5 I have added a tombstone bool on the index Value. I thinks it's the good option

Just a question : https://github.com/thomasjungblut/go-sstables/blob/d00463f192d4d4126a04a6ac66aa18fd26f44995/sstables/sstable_merger.go#L41 https://github.com/thomasjungblut/go-sstables/blob/d00463f192d4d4126a04a6ac66aa18fd26f44995/sstables/sstable_merger.go#L120 There is two merge method. I don't really understand the difference. And I don't understand the need of the context.

Thanks for the response. But what about the context ?

very interesting... And what are the bench results ?