Sabart Otto

Results 63 comments of Sabart Otto

I've moved the decorator which adds the `properties` to `tmt.Result` into the `junit` module (related PR https://github.com/teemtee/tmt/pull/3166). Hopefully, it's better now :).

Could someone help me fix the tests? I'm having trouble understanding why they are failing and whether the errors are related to my pull request. Is it possible that the...

> Could someone help me fix the tests? I'm having trouble understanding why they are failing and whether the errors are related to my pull request. Is it possible that...

As discussed today, I've tried to fix the lxml dependency and converted the `time=""` attributes to float using a jinja filter. Also, the float times are now enforced by `default.xsd`...

> `time` is probably not in float? > > ``` > FAILED test_report_junit.py::TestStateMapping::test_pass - AssertionError: Attribute mismatch at #document.testsuites.testsuite: found time="0.0" > assert '0' == '0.0' > ``` It was...

> Looks good, thanks! Just one nitpick. Would be good to include at least a simple `results.yaml` example together with a test which would check the output is as expected....

The phase checks should be also shown. Example: ![phase-checks](https://github.com/user-attachments/assets/b154242a-15a0-4fb4-a82c-1e1a72174802)

> Just a note: in the light of renaming "phase" to "subresult", either this PR or #3106 will require changes to produce the consistent subresults-in-html-report picture. #3106 seems to be...

Just an update of screenshots. The #3106 is still a prerequisite. My testing data: ``` ... subresult: - name: /tests/mine-rep-multi/test/good result: pass end-time: "2024-07-17T14:16:28.735039+00:00" __class__: module: tmt.result name: SubResult -...