grunt-rev icon indicating copy to clipboard operation
grunt-rev copied to clipboard

Published 20 hours ago • verified publisher icon sebdeckers

suffix/postfix naming

Open orand opened this issue 12 years ago • 7 comments

This adds suffix/postfix naming support as described in #2.

Note: to avoid breaking compatibility with yeoman/grunt-usemin, please do not accept this pull request until yeoman/grunt-usemin#113 has been merged into the v2.0 branch and the v2.0 branch has been merged into master.

orand avatar May 15 '13 19:05 orand

@cbas : we need to coordinate ;)

sleeper avatar May 16 '13 04:05 sleeper

Why is it necessary to wait on another task before this can be merged in?

necolas avatar May 16 '13 22:05 necolas

This new naming scheme was designed to work together with usemin 2.0 which hasn't been released yet. Merging it now will break compatibility with usemin 1.x which is the currently released version.

orand avatar May 16 '13 22:05 orand

This task is also useful standalone and at the moment I have to point to a sha on the fork just to get this small change.

I'm not clear about how usemin 1.x would be affected by a separate task cutting a new release. It feels like that shouldn't be allowed to happen. Whatever is going on there, could that be fixed so as not to hold up change in this task while usemin is being rewritten? Thanks :)

necolas avatar May 16 '13 22:05 necolas

+1 looking forward to the merge

jfroom avatar Aug 14 '13 17:08 jfroom

@jfroom Done in grunt-filerev

sleeper avatar Aug 14 '13 18:08 sleeper

@cbas Is there any further reason this couldn't be merged?

Ianfeather avatar May 25 '14 08:05 Ianfeather